Bug 121934 - Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*
Summary: Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 18:43 PDT by Sam Weinig
Modified: 2013-09-26 12:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (42.35 KB, patch)
2013-09-25 18:47 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (44.57 KB, patch)
2013-09-25 19:20 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (44.58 KB, patch)
2013-09-25 19:43 PDT, Sam Weinig 		ggaren: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-25 18:43:00 PDT 
Pass a JSC::VM& to JS bindings object creation functions, rather than a JSC::ExecState*
Comment 1 Sam Weinig 2013-09-25 18:47:10 PDT 
Created attachment 212650 [details]
Patch
Comment 2 Sam Weinig 2013-09-25 18:47:33 PDT 
This will probably take a few tries, so first let's let the bots at it.
Comment 3 WebKit Commit Bot 2013-09-25 18:49:35 PDT 
Attachment 212650 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1
Source/WebCore/bridge/c/CRuntimeObject.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Early Warning System Bot 2013-09-25 18:57:24 PDT 
Comment on attachment 212650 [details]
Patch

Attachment 212650 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2230095
Comment 5 Early Warning System Bot 2013-09-25 18:58:41 PDT 
Comment on attachment 212650 [details]
Patch

Attachment 212650 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2202081
Comment 6 Sam Weinig 2013-09-25 19:20:19 PDT 
Created attachment 212653 [details]
Patch
Comment 7 WebKit Commit Bot 2013-09-25 19:21:52 PDT 
Attachment 212653 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1
Source/WebCore/bridge/c/CRuntimeObject.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Early Warning System Bot 2013-09-25 19:32:18 PDT 
Comment on attachment 212653 [details]
Patch

Attachment 212653 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2165116
Comment 9 Early Warning System Bot 2013-09-25 19:33:46 PDT 
Comment on attachment 212653 [details]
Patch

Attachment 212653 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2209115
Comment 10 Sam Weinig 2013-09-25 19:43:58 PDT 
Created attachment 212655 [details]
Patch
Comment 11 WebKit Commit Bot 2013-09-25 19:45:10 PDT 
Attachment 212655 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/bindings/js/JSDOMBinding.h', u'Source/WebCore/bindings/js/JSDOMGlobalObject.h', u'Source/WebCore/bindings/js/JSDOMWindowCustom.cpp', u'Source/WebCore/bindings/js/JSDocumentCustom.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.cpp', u'Source/WebCore/bindings/js/JSImageConstructor.h', u'Source/WebCore/bindings/js/ScriptWrappable.h', u'Source/WebCore/bindings/js/ScriptWrappableInlines.h', u'Source/WebCore/bindings/scripts/CodeGeneratorJS.pm', u'Source/WebCore/bridge/c/CRuntimeObject.cpp', u'Source/WebCore/bridge/c/CRuntimeObject.h', u'Source/WebCore/bridge/c/c_instance.cpp', u'Source/WebCore/bridge/jsc/BridgeJSC.cpp', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.h', u'Source/WebCore/bridge/objc/ObjCRuntimeObject.mm', u'Source/WebCore/bridge/objc/objc_instance.mm', u'Source/WebCore/bridge/objc/objc_runtime.h', u'Source/WebCore/bridge/qt/qt_instance.cpp', u'Source/WebCore/bridge/runtime_array.h', u'Source/WebCore/bridge/runtime_method.h', u'Source/WebCore/bridge/runtime_object.cpp', u'Source/WebCore/bridge/runtime_object.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Plugins/Hosted/ProxyInstance.mm', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.h', u'Source/WebKit/mac/Plugins/Hosted/ProxyRuntimeObject.mm']" exit_code: 1
Source/WebCore/bridge/c/CRuntimeObject.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Geoffrey Garen 2013-09-25 20:13:17 PDT 
Comment on attachment 212655 [details]
Patch

r=me
Comment 13 Sam Weinig 2013-09-26 12:07:45 PDT 
Committed r156485: <http://trac.webkit.org/changeset/156485>