Bug 121919 - JS wrappers should have strongly typed impl() functions.
Summary: JS wrappers should have strongly typed impl() functions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 12:03 PDT by Andreas Kling
Modified: 2013-09-25 13:00 PDT (History)
8 users (show)

See Also:


Attachments
Patch (55.12 KB, patch)
2013-09-25 12:06 PDT, Andreas Kling
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-25 12:03:14 PDT
We should generate strongly-typed JSFoo::impl() for every wrapper class, not just those marked with JSGenerateToNativeObject.
This'll reduce the need for magical casting all over WebCore.
Comment 1 Andreas Kling 2013-09-25 12:06:46 PDT
Created attachment 212613 [details]
Patch
Comment 2 Geoffrey Garen 2013-09-25 12:23:29 PDT
Comment on attachment 212613 [details]
Patch

Please update run-bindings-tests results before landing.
Comment 3 Antonio Gomes 2013-09-25 12:32:22 PDT
Comment on attachment 212613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212613&action=review

> Source/WebCore/ChangeLog:9
> +        not just those marked with JSGenerateToNativeObject.

is JSGenerateToNativeObject support still needed by now?
Comment 4 Andreas Kling 2013-09-25 12:33:58 PDT
(In reply to comment #3)
> (From update of attachment 212613 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212613&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        not just those marked with JSGenerateToNativeObject.
> 
> is JSGenerateToNativeObject support still needed by now?

Yes, it's still needed for objects that want an autogenerated toWebCoreFoo() function.
Comment 5 Andreas Kling 2013-09-25 13:00:24 PDT
Committed r156419: <http://trac.webkit.org/changeset/156419>