Bug 121900 - Fix warning in makeprop.pl
Summary: Fix warning in makeprop.pl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-25 04:40 PDT by Alberto Garcia
Modified: 2013-09-25 09:07 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.15 KB, patch)
2013-09-25 04:42 PDT, Alberto Garcia 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-09-25 04:40:19 PDT 
After r155511:

Reference found where even-sized list expected at ../../Source/WebCore/css/makeprop.pl line 42.
Reference found where even-sized list expected at ../../Source/WebCore/css/makeprop.pl line 43.

The problem is here:

my %nameIsInherited = {};
my %nameToId = {};

{} is not an empty hash, it's a _reference_ to an empty hash.
Hashes are initialized using lists, with ().

Anyway, there's no need to initialize it explicitly to () either since that's already the default value.
Comment 1 Alberto Garcia 2013-09-25 04:42:58 PDT 
Created attachment 212552 [details]
Patch
Comment 2 Alberto Garcia 2013-09-25 09:07:06 PDT 
Committed r156400: <http://trac.webkit.org/changeset/156400>