Bug 121895 - Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore
Summary: Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 22:26 PDT by Sam Weinig
Modified: 2013-09-24 22:35 PDT (History)
0 users

See Also:

Attachments
Patch (2.34 KB, patch)
2013-09-24 22:27 PDT, Sam Weinig 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-24 22:26:37 PDT 
Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore
Comment 1 Sam Weinig 2013-09-24 22:27:01 PDT 
Created attachment 212540 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-09-24 22:31:46 PDT 
Comment on attachment 212540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review

> Source/WebKit2/DerivedSources.make:1
> -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved.
> +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.

Did we change this file this year? I don't think that removing code gives you copyright.

> Source/WebKit2/DerivedSources.make:-139
> -# Mac-specific rules
> -
> -ifeq ($(PLATFORM_NAME),macosx)

These changes are not mentioned in ChangeLog, and surprised me.

Looks like this file is only used on Mac.
Comment 3 Sam Weinig 2013-09-24 22:34:46 PDT 
(In reply to comment #2)
> (From update of attachment 212540 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review
> 
> > Source/WebKit2/DerivedSources.make:1
> > -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved.
> > +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
> 
> Did we change this file this year? I don't think that removing code gives you copyright.
> 

We did. r142518 for instance.

> > Source/WebKit2/DerivedSources.make:-139
> > -# Mac-specific rules
> > -
> > -ifeq ($(PLATFORM_NAME),macosx)
> 
> These changes are not mentioned in ChangeLog, and surprised me.
> 
> Looks like this file is only used on Mac.

Right, I think DerivedSources.make is only used by Mac and Windows. And without Windows, it only leaves Mac :).  I'll fix the ChangeLog.
Comment 4 Sam Weinig 2013-09-24 22:35:49 PDT 
Committed r156384: <http://trac.webkit.org/changeset/156384>