Bug 121895 – Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore

[Sam Weinig]

Created attachment 212540 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 212540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review

> Source/WebKit2/DerivedSources.make:1
> -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved.
> +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.

Did we change this file this year? I don't think that removing code gives you copyright.

> Source/WebKit2/DerivedSources.make:-139
> -# Mac-specific rules
> -
> -ifeq ($(PLATFORM_NAME),macosx)

These changes are not mentioned in ChangeLog, and surprised me.

Looks like this file is only used on Mac.

[Sam Weinig]

(In reply to comment #2)
> (From update of attachment 212540 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212540&action=review
> 
> > Source/WebKit2/DerivedSources.make:1
> > -# Copyright (C) 2010, 2011, 2012 Apple Inc. All rights reserved.
> > +# Copyright (C) 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
> 
> Did we change this file this year? I don't think that removing code gives you copyright.
> 

We did. r142518 for instance.

> > Source/WebKit2/DerivedSources.make:-139
> > -# Mac-specific rules
> > -
> > -ifeq ($(PLATFORM_NAME),macosx)
> 
> These changes are not mentioned in ChangeLog, and surprised me.
> 
> Looks like this file is only used on Mac.

Right, I think DerivedSources.make is only used by Mac and Windows. And without Windows, it only leaves Mac :).  I'll fix the ChangeLog.

[Sam Weinig]

Committed r156384: <http://trac.webkit.org/changeset/156384>