RESOLVED FIXED 121890
Remove EventPathWalker. 
https://bugs.webkit.org/show_bug.cgi?id=121890
Summary Remove EventPathWalker.
Andreas Kling
Reported 2013-09-24 19:19:01 PDT
Let's lose some more Shadow DOM gunk.
Attachments
Patch for bots (11.39 KB, patch)
2013-09-24 19:19 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (462.85 KB, application/zip)
2013-09-24 20:07 PDT, Build Bot 		no flags
Details
Patch for bots (11.60 KB, patch)
2013-09-24 20:23 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (12.97 KB, patch)
2013-09-25 05:26 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (19.33 KB, patch)
2013-09-25 05:27 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-24 19:19:32 PDT
Created attachment 212531 [details] Patch for bots
WebKit Commit Bot
Comment 2 2013-09-24 19:20:32 PDT
Attachment 212531 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventPathWalker.cpp', u'Source/WebCore/dom/EventPathWalker.h', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/page/EventHandler.cpp']" exit_code: 1 Source/WebCore/dom/EventPathWalker.cpp:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Source/WebCore/dom/EventPathWalker.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2013-09-24 20:07:43 PDT
Comment on attachment 212531 [details] Patch for bots Attachment 212531 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2233008 New failing tests: fast/css-generated-content/pseudo-transition-event.html
Build Bot
Comment 4 2013-09-24 20:07:45 PDT
Created attachment 212533 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Andreas Kling
Comment 5 2013-09-24 20:23:57 PDT
Created attachment 212534 [details] Patch for bots Fix pseudo element events.
WebKit Commit Bot
Comment 6 2013-09-24 20:53:22 PDT
Attachment 212534 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventPathWalker.cpp', u'Source/WebCore/dom/EventPathWalker.h', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/html/HTMLLIElement.cpp', u'Source/WebCore/page/EventHandler.cpp']" exit_code: 1 Source/WebCore/dom/EventPathWalker.cpp:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Source/WebCore/dom/EventPathWalker.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 7 2013-09-24 21:26:35 PDT
Comment on attachment 212534 [details] Patch for bots View in context: https://bugs.webkit.org/attachment.cgi?id=212534&action=review > Source/WebCore/dom/EventRetargeter.cpp:77 > +static Node* nodeOrHostIfPseudoPseudoElement(Node* node) Needs more Pseudo.
Andreas Kling
Comment 8 2013-09-25 05:26:00 PDT
Created attachment 212561 [details] Patch
Andreas Kling
Comment 9 2013-09-25 05:27:57 PDT
Created attachment 212562 [details] Patch With build systems.
WebKit Commit Bot
Comment 10 2013-09-25 06:01:11 PDT
Comment on attachment 212562 [details] Patch Clearing flags on attachment: 212562 Committed r156390: <http://trac.webkit.org/changeset/156390>
WebKit Commit Bot
Comment 11 2013-09-25 06:01:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.