Bug 121886 – Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Gyuyoung Kim]

As mentioned in https://bugs.webkit.org/show_bug.cgi?id=121776#c3, toWebKitCSSShaderValue() behavior is different from other toCSSFooValue(). We need to have same behavior pattern. Patch is coming.

[Gyuyoung Kim]

Created attachment 212671 [details]
Patch

[Early Warning System Bot]

Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2343005

[Early Warning System Bot]

Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2260089

[Build Bot]

Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2193253

[Build Bot]

Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2334009

[Gyuyoung Kim]

Created attachment 212677 [details]
Patch

[Build Bot]

Comment on attachment 212677 [details]
Patch

Attachment 212677 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2233204

New failing tests:
css3/filters/custom/custom-filter-animation.html
css3/filters/custom/custom-filter-u-mesh-box.html
css3/filters/custom/custom-filter-array-blending.html
css3/filters/custom/custom-filter-matN.html
css3/filters/custom/custom-filter-u-tile-size.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
css3/filters/custom/custom-filter-array.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-clamp-css-color-matrix.html
css3/filters/custom/effect-custom-transform-parameters.html
css3/filters/custom/custom-filter-transforms-animation.html
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-composite-fractional-source-alpha.html
css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html
css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/composited/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-change-blend-mode.html

[Build Bot]

Created attachment 212682 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 212677 [details]
Patch

Attachment 212677 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2393026

New failing tests:
css3/filters/custom/custom-filter-animation.html
css3/filters/custom/custom-filter-u-mesh-box.html
css3/filters/custom/custom-filter-array-blending.html
css3/filters/custom/custom-filter-matN.html
css3/filters/custom/custom-filter-u-tile-size.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
css3/filters/custom/custom-filter-array.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-clamp-css-color-matrix.html
css3/filters/custom/effect-custom-transform-parameters.html
css3/filters/custom/custom-filter-transforms-animation.html
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-composite-fractional-source-alpha.html
css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html
css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/composited/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-change-blend-mode.html

[Build Bot]

Created attachment 212684 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 212677 [details]
Patch

Attachment 212677 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2425040

New failing tests:
css3/filters/custom/custom-filter-animation.html
css3/filters/custom/custom-filter-u-mesh-box.html
css3/filters/custom/custom-filter-array-blending.html
css3/filters/custom/custom-filter-matN.html
css3/filters/custom/custom-filter-u-tile-size.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
css3/filters/custom/custom-filter-array.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-clamp-css-color-matrix.html
css3/filters/custom/effect-custom-transform-parameters.html
css3/filters/custom/custom-filter-transforms-animation.html
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-composite-fractional-source-alpha.html
css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html
css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/composited/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-change-blend-mode.html

[Build Bot]

Created attachment 212692 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Ryosuke Niwa]

Comment on attachment 212677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review

> Source/WebCore/css/StyleResolver.cpp:3626
> +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())

Exiting early here changes the behavior

[Gyuyoung Kim]

Comment on attachment 212677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review

>> Source/WebCore/css/StyleResolver.cpp:3626
>> +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())
> 
> Exiting early here changes the behavior

How about changing this as below ?

WebKitCSSShaderValue* vertexShader = 0;
WebKitCSSShaderValue* fragmentShader = 0;

if (shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())
    vertexShader = toWebKitCSSShaderValue(shadersList->itemWithoutBoundsCheck(0));

[Gyuyoung Kim]

Created attachment 212718 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #13)
> (From update of attachment 212677 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review
> 
> > Source/WebCore/css/StyleResolver.cpp:3626
> > +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())
> 
> Exiting early here changes the behavior

rniwa, what do you think about latest patch ?

[WebKit Commit Bot]

Comment on attachment 212718 [details]
Patch

Clearing flags on attachment: 212718

Committed r156528: <http://trac.webkit.org/changeset/156528>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.