Bug 121886 - Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
Summary: Sync toWebKitCSSShaderValue() behavior with other toCSSFooValue()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 17:50 PDT by Gyuyoung Kim
Modified: 2013-09-26 20:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2013-09-26 00:07 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.57 KB, patch)
2013-09-26 02:02 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (717.11 KB, application/zip)
2013-09-26 02:54 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (728.25 KB, application/zip)
2013-09-26 03:08 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (733.02 KB, application/zip)
2013-09-26 04:11 PDT, Build Bot 		no flags Details
Patch (3.71 KB, patch)
2013-09-26 09:34 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-09-24 17:50:32 PDT 
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=121776#c3, toWebKitCSSShaderValue() behavior is different from other toCSSFooValue(). We need to have same behavior pattern. Patch is coming.
Comment 1 Gyuyoung Kim 2013-09-26 00:07:24 PDT 
Created attachment 212671 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-26 00:12:04 PDT 
Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2343005
Comment 3 Early Warning System Bot 2013-09-26 00:13:23 PDT 
Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2260089
Comment 4 Build Bot 2013-09-26 00:34:12 PDT 
Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2193253
Comment 5 Build Bot 2013-09-26 00:47:29 PDT 
Comment on attachment 212671 [details]
Patch

Attachment 212671 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2334009
Comment 6 Gyuyoung Kim 2013-09-26 02:02:35 PDT 
Created attachment 212677 [details]
Patch
Comment 7 Build Bot 2013-09-26 02:54:51 PDT 
Comment on attachment 212677 [details]
Patch

Attachment 212677 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2233204

New failing tests:
css3/filters/custom/custom-filter-animation.html
css3/filters/custom/custom-filter-u-mesh-box.html
css3/filters/custom/custom-filter-array-blending.html
css3/filters/custom/custom-filter-matN.html
css3/filters/custom/custom-filter-u-tile-size.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
css3/filters/custom/custom-filter-array.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-clamp-css-color-matrix.html
css3/filters/custom/effect-custom-transform-parameters.html
css3/filters/custom/custom-filter-transforms-animation.html
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-composite-fractional-source-alpha.html
css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html
css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/composited/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-change-blend-mode.html
Comment 8 Build Bot 2013-09-26 02:54:54 PDT 
Created attachment 212682 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 9 Build Bot 2013-09-26 03:08:43 PDT 
Comment on attachment 212677 [details]
Patch

Attachment 212677 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2393026

New failing tests:
css3/filters/custom/custom-filter-animation.html
css3/filters/custom/custom-filter-u-mesh-box.html
css3/filters/custom/custom-filter-array-blending.html
css3/filters/custom/custom-filter-matN.html
css3/filters/custom/custom-filter-u-tile-size.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
css3/filters/custom/custom-filter-array.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-clamp-css-color-matrix.html
css3/filters/custom/effect-custom-transform-parameters.html
css3/filters/custom/custom-filter-transforms-animation.html
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-composite-fractional-source-alpha.html
css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html
css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/composited/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-change-blend-mode.html
Comment 10 Build Bot 2013-09-26 03:08:47 PDT 
Created attachment 212684 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 Build Bot 2013-09-26 04:11:16 PDT 
Comment on attachment 212677 [details]
Patch

Attachment 212677 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/2425040

New failing tests:
css3/filters/custom/custom-filter-animation.html
css3/filters/custom/custom-filter-u-mesh-box.html
css3/filters/custom/custom-filter-array-blending.html
css3/filters/custom/custom-filter-matN.html
css3/filters/custom/custom-filter-u-tile-size.html
css3/filters/custom/custom-filter-property-computed-style.html
css3/filters/custom/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-clamp-css-mix-color.html
css3/filters/custom/custom-filter-array.html
css3/filters/custom/custom-filter-u-texture-size.html
css3/filters/custom/custom-filter-clamp-css-color-matrix.html
css3/filters/custom/effect-custom-transform-parameters.html
css3/filters/custom/custom-filter-transforms-animation.html
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html
css3/filters/custom/custom-filter-composite-fractional-source-alpha.html
css3/filters/custom/custom-filter-clamp-css-color-matrix-negative.html
css3/filters/custom/custom-filter-u-mesh-size.html
css3/filters/custom/composited/custom-filter-blend-modes.html
css3/filters/custom/custom-filter-change-blend-mode.html
Comment 12 Build Bot 2013-09-26 04:11:19 PDT 
Created attachment 212692 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 13 Ryosuke Niwa 2013-09-26 06:53:12 PDT 
Comment on attachment 212677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review

> Source/WebCore/css/StyleResolver.cpp:3626
> +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())

Exiting early here changes the behavior
Comment 14 Gyuyoung Kim 2013-09-26 07:29:00 PDT 
Comment on attachment 212677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review

>> Source/WebCore/css/StyleResolver.cpp:3626
>> +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())
> 
> Exiting early here changes the behavior

How about changing this as below ?

WebKitCSSShaderValue* vertexShader = 0;
WebKitCSSShaderValue* fragmentShader = 0;

if (shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())
    vertexShader = toWebKitCSSShaderValue(shadersList->itemWithoutBoundsCheck(0));
Comment 15 Gyuyoung Kim 2013-09-26 09:34:00 PDT 
Created attachment 212718 [details]
Patch
Comment 16 Gyuyoung Kim 2013-09-26 16:25:40 PDT 
(In reply to comment #13)
> (From update of attachment 212677 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212677&action=review
> 
> > Source/WebCore/css/StyleResolver.cpp:3626
> > +    if (!shadersList->itemWithoutBoundsCheck(0)->isWebKitCSSShaderValue())
> 
> Exiting early here changes the behavior

rniwa, what do you think about latest patch ?
Comment 17 WebKit Commit Bot 2013-09-26 20:25:41 PDT 
Comment on attachment 212718 [details]
Patch

Clearing flags on attachment: 212718

Committed r156528: <http://trac.webkit.org/changeset/156528>
Comment 18 WebKit Commit Bot 2013-09-26 20:25:45 PDT 
All reviewed patches have been landed.  Closing bug.