Bug 121885 - [Windows] Overpanning occurs even when what is being panned isn't the main document
Summary: [Windows] Overpanning occurs even when what is being panned isn't the main do...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-24 17:38 PDT by Roger Fong
Modified: 2013-09-25 16:25 PDT (History)
9 users (show)

See Also:

Attachments
patch (6.72 KB, patch)
2013-09-24 17:47 PDT, Roger Fong 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-09-24 17:38:14 PDT 
When calling scrollbyrecursively we current keep track of the scrolled scrollview. 
However this does not take overflow scrolls into account.

Hence what we see is that when we are panning an overflow scroll but the main document's scroll position is at either the beginning or end, 
overpanning occurs.

We should instead keep track of the ScrollableArea since that encompasses both overflow scrolls and scroll views.

<rdar://problem/15072332>
Comment 1 Roger Fong 2013-09-24 17:47:25 PDT 
Created attachment 212527 [details]
patch
Comment 2 Roger Fong 2013-09-25 11:34:31 PDT 
Note that as of right now, only the Windows port uses the third argument in this method, and hence is the only one affected by this change.
Comment 3 Brent Fulgham 2013-09-25 11:36:51 PDT 
Comment on attachment 212527 [details]
patch

r=me
Comment 4 Roger Fong 2013-09-25 12:05:04 PDT 
Committed: http://trac.webkit.org/changeset/156416