Bug 121882 - Clean up some uses of first/lastChildSlow
Summary: Clean up some uses of first/lastChildSlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 17:14 PDT by Antti Koivisto
Modified: 2013-09-24 18:00 PDT (History)
0 users

See Also:

Attachments
patch (22.33 KB, patch)
2013-09-24 17:20 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-24 17:14:28 PDT 
tighten typing
Comment 1 Antti Koivisto 2013-09-24 17:20:47 PDT 
Created attachment 212525 [details]
patch
Comment 2 Andreas Kling 2013-09-24 17:31:28 PDT 
Comment on attachment 212525 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212525&action=review

r=me

> Source/WebCore/dom/Position.cpp:857
> +    for (RenderObject *o = renderer.firstChild(); o && o != stop; o = o->nextInPreOrder())

* placement

> Source/WebCore/rendering/RenderBlock.cpp:1074
> +    if (anonymousBlock->continuation() || anonymousBlock->beingDestroyed())
>          return false;

We should postpone the continuation() check if possible, since it does a hash lookup.

> Source/WebCore/rendering/RenderBlock.cpp:5956
> -    RenderObject* firstLetterBlock = findFirstLetterBlock(this);
> +    RenderElement* firstLetterBlock = findFirstLetterBlock(this);

I think we can make findFirstLetterBlock() return RenderBlock*.
Comment 3 Antti Koivisto 2013-09-24 18:00:32 PDT 
https://trac.webkit.org/r156377