Bug 121869 - WinCairo shouldn't check AAS
Summary: WinCairo shouldn't check AAS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 14:34 PDT by Alex Christensen
Modified: 2013-09-25 18:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.96 KB, patch)
2013-09-24 14:35 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2013-09-24 14:36 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2013-09-25 12:20 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.86 KB, patch)
2013-09-25 16:47 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (10.28 KB, patch)
2013-09-25 17:08 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-09-24 14:34:32 PDT
Right now, WinCairo's WinLauncher cannot be used without installing the QuickTime or old Safari on the computer.  I would like my daily builds to be able to be used with as few dependencies as possible.  This patch would narrow that down to only the VS2010 redistributables.
Comment 1 Alex Christensen 2013-09-24 14:35:22 PDT
Created attachment 212505 [details]
Patch
Comment 2 Alex Christensen 2013-09-24 14:36:36 PDT
Created attachment 212506 [details]
Patch
Comment 3 Alex Christensen 2013-09-25 12:20:06 PDT
Created attachment 212616 [details]
Patch
Comment 4 Alex Christensen 2013-09-25 16:47:18 PDT
Created attachment 212639 [details]
Patch
Comment 5 Brent Fulgham 2013-09-25 17:03:53 PDT
Comment on attachment 212639 [details]
Patch

The DLLLauncherWinCairo.props is being added improperly.   Turn off the svn:executable bit, and remove the svn:mime-type property so that it will be added as an XML text file.
Comment 6 Alex Christensen 2013-09-25 17:08:55 PDT
Created attachment 212642 [details]
Patch
Comment 7 Brent Fulgham 2013-09-25 17:20:35 PDT
Comment on attachment 212642 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2013-09-25 18:04:01 PDT
Comment on attachment 212642 [details]
Patch

Clearing flags on attachment: 212642

Committed r156440: <http://trac.webkit.org/changeset/156440>
Comment 9 WebKit Commit Bot 2013-09-25 18:04:04 PDT
All reviewed patches have been landed.  Closing bug.