Bug 121840 - Cache continuation() in a local to avoid repeat hash lookups.
Summary: Cache continuation() in a local to avoid repeat hash lookups.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 08:10 PDT by Andreas Kling
Modified: 2013-09-24 09:19 PDT (History)
12 users (show)

See Also:

Attachments
Patch (6.41 KB, patch)
2013-09-24 08:16 PDT, Andreas Kling 		ggaren: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch for laundry (6.41 KB, patch)
2013-09-24 08:46 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-24 08:10:54 PDT 
RenderBoxModelObject's continuation() does a hash lookup so calling it repeatedly is not super cool.
Comment 1 Andreas Kling 2013-09-24 08:16:13 PDT 
Created attachment 212468 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-24 08:21:09 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1908496
Comment 3 Early Warning System Bot 2013-09-24 08:23:29 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2004627
Comment 4 EFL EWS Bot 2013-09-24 08:25:14 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2110241
Comment 5 EFL EWS Bot 2013-09-24 08:26:50 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2004629
Comment 6 kov's GTK+ EWS bot 2013-09-24 08:30:37 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1960269
Comment 7 Geoffrey Garen 2013-09-24 08:36:56 PDT 
Comment on attachment 212468 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212468&action=review

r=me, plz fix build -- see below

> Source/WebCore/rendering/RenderInline.cpp:1439
> +            continuation->addFocusRingRects(rects, flooredLayoutPoint(additionalOffset + toRenderBox(continuation())->location() - containingBlock()->location()), paintContainer);

Nix the parens on 'continuation' here.
Comment 8 Build Bot 2013-09-24 08:45:23 PDT 
Comment on attachment 212468 [details]
Patch

Attachment 212468 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1908503
Comment 9 Andreas Kling 2013-09-24 08:46:24 PDT 
Created attachment 212471 [details]
Patch for laundry
Comment 10 WebKit Commit Bot 2013-09-24 09:19:08 PDT 
Comment on attachment 212471 [details]
Patch for laundry

Clearing flags on attachment: 212471

Committed r156334: <http://trac.webkit.org/changeset/156334>
Comment 11 WebKit Commit Bot 2013-09-24 09:19:11 PDT 
All reviewed patches have been landed.  Closing bug.