RESOLVED FIXED 121834
[WIN] Add missing USE(CFNETWORK) to WebError.h 
https://bugs.webkit.org/show_bug.cgi?id=121834
Summary [WIN] Add missing USE(CFNETWORK) to WebError.h
Patrick R. Gansterer
Reported 2013-09-24 04:03:05 PDT
[WIN] Add missing USE(CFNETWORK) to WebError.h
Attachments
Patch (999 bytes, patch)
2013-09-24 04:05 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-09-24 04:05:37 PDT
Created attachment 212450 [details] Patch
Brent Fulgham
Comment 2 2013-09-25 11:43:45 PDT
Comment on attachment 212450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against. > Source/WebKit/win/WebError.h:93 > +#if USE(CFNETWORK) This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against.
Patrick R. Gansterer
Comment 3 2013-09-25 11:56:45 PDT
Comment on attachment 212450 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review >> Source/WebKit/win/WebError.h:93 >> +#if USE(CFNETWORK) > > This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against. But it's only used by CFNETWORK code. See http://trac.webkit.org/browser/trunk/Source/WebKit/win/WebError.cpp?rev=149716#L218
Brent Fulgham
Comment 4 2013-10-30 10:13:03 PDT
Comment on attachment 212450 [details] Patch Okay. r=me
WebKit Commit Bot
Comment 5 2013-10-30 10:31:56 PDT
Comment on attachment 212450 [details] Patch Clearing flags on attachment: 212450 Committed r158278: <http://trac.webkit.org/changeset/158278>
WebKit Commit Bot
Comment 6 2013-10-30 10:31:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.