Bug 121834 - [WIN] Add missing USE(CFNETWORK) to WebError.h
Summary: [WIN] Add missing USE(CFNETWORK) to WebError.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 04:03 PDT by Patrick R. Gansterer
Modified: 2013-10-30 10:31 PDT (History)
1 user (show)

See Also:

Attachments
Patch (999 bytes, patch)
2013-09-24 04:05 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-09-24 04:03:05 PDT 
[WIN] Add missing USE(CFNETWORK) to WebError.h
Comment 1 Patrick R. Gansterer 2013-09-24 04:05:37 PDT 
Created attachment 212450 [details]
Patch
Comment 2 Brent Fulgham 2013-09-25 11:43:45 PDT 
Comment on attachment 212450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review

This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against.

> Source/WebKit/win/WebError.h:93
> +#if USE(CFNETWORK)

This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against.
Comment 3 Patrick R. Gansterer 2013-09-25 11:56:45 PDT 
Comment on attachment 212450 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212450&action=review

>> Source/WebKit/win/WebError.h:93
>> +#if USE(CFNETWORK)
> 
> This should be USE(CF), as it's a CFDictionaryRef we are trying to protect against.

But it's only used by CFNETWORK code. See http://trac.webkit.org/browser/trunk/Source/WebKit/win/WebError.cpp?rev=149716#L218
Comment 4 Brent Fulgham 2013-10-30 10:13:03 PDT 
Comment on attachment 212450 [details]
Patch

Okay. r=me
Comment 5 WebKit Commit Bot 2013-10-30 10:31:56 PDT 
Comment on attachment 212450 [details]
Patch

Clearing flags on attachment: 212450

Committed r158278: <http://trac.webkit.org/changeset/158278>
Comment 6 WebKit Commit Bot 2013-10-30 10:31:57 PDT 
All reviewed patches have been landed.  Closing bug.