Bug 121832 - [CMake] Add precompiled header for MSVC in WebCore
Summary: [CMake] Add precompiled header for MSVC in WebCore
Status: RESOLVED DUPLICATE of bug 115944
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-24 03:26 PDT by Patrick R. Gansterer
Modified: 2015-12-10 11:04 PST (History)
6 users (show)

See Also:

Attachments
Patch (2.34 KB, patch)
2013-09-24 03:28 PDT, Patrick R. Gansterer 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (2.55 KB, patch)
2013-09-24 03:42 PDT, Patrick R. Gansterer 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2013-09-24 03:49 PDT, Patrick R. Gansterer 		achristensen: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-09-24 03:26:07 PDT 
[CMake] Add precompiled header for MSVC in WebCore
Comment 1 Patrick R. Gansterer 2013-09-24 03:28:28 PDT 
Created attachment 212445 [details]
Patch
Comment 2 EFL EWS Bot 2013-09-24 03:32:39 PDT 
Comment on attachment 212445 [details]
Patch

Attachment 212445 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2053283
Comment 3 EFL EWS Bot 2013-09-24 03:32:56 PDT 
Comment on attachment 212445 [details]
Patch

Attachment 212445 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2012281
Comment 4 Patrick R. Gansterer 2013-09-24 03:42:47 PDT 
Created attachment 212447 [details]
Patch
Comment 5 EFL EWS Bot 2013-09-24 03:45:59 PDT 
Comment on attachment 212447 [details]
Patch

Attachment 212447 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2062244
Comment 6 EFL EWS Bot 2013-09-24 03:46:29 PDT 
Comment on attachment 212447 [details]
Patch

Attachment 212447 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/2109192
Comment 7 Patrick R. Gansterer 2013-09-24 03:49:04 PDT 
Created attachment 212448 [details]
Patch
Comment 8 Gyuyoung Kim 2013-09-25 03:33:38 PDT 
Comment on attachment 212448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212448&action=review

> Source/WebCore/ChangeLog:7
> +

Description ?

> Source/WebCore/WebCorePrefix.h:30
> +#ifdef BUILDING_WITH_CMAKE

It seems to me that this cmakeconfig.h is included by all cmake ports, not only MSVC. Dont' you need to change bug title ? Or, need to mention it in ChangeLog ?
Comment 9 Alex Christensen 2015-12-09 23:50:00 PST 
Comment on attachment 212448 [details]
Patch

This was done using the ADD_PRECOMPILED_HEADER macro in http://trac.webkit.org/changeset/182545
Once again, thanks for the early CMake work you did, Patrick.  CMake is now the default build system for Windows.
Comment 10 Brent Fulgham 2015-12-10 08:47:17 PST 
(In reply to comment #9)
> Comment on attachment 212448 [details]
> Patch
> 
> This was done using the ADD_PRECOMPILED_HEADER macro in
> http://trac.webkit.org/changeset/182545
> Once again, thanks for the early CMake work you did, Patrick.  CMake is now
> the default build system for Windows.

Is this patch no longer needed? Why not close the bug?
Comment 11 Alex Christensen 2015-12-10 11:04:24 PST 

*** This bug has been marked as a duplicate of bug 115944 ***