Bug 121827 – [WIN] Reduce usage of CFSTR() in WebPreferences

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Patrick R. Gansterer]

[WIN] Reduce usage of CFSTR() in WebPreferences

[Patrick R. Gansterer]

Created attachment 212437 [details]
Patch

[Brent Fulgham]

Comment on attachment 212437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212437&action=review

This seems reasonable, since it doesn't change any of the interfaces we are working with

Be careful with changes here: we want to make sure that we don't break any existing functionality -- there are existing serialized preference databases that rely on the CF infrastructure to read and modify.

This change will not affect any of those targets, but when  you start modifying "migrateWebKitPreferencesToCFPreferences" or "copyWebKitPreferencesToCFPreferences" and especially "load" and "save" you have to be very careful.

> Source/WebKit/win/WebPreferences.cpp:320
> +BSTR WebPreferences::stringValueForKey(const char* key)

Note (for your future modifications): This routine (and several others) could greatly benefit from using _bstr_t instead of all of this manual SysAllocStringLen stuff.

[WebKit Commit Bot]

Comment on attachment 212437 [details]
Patch

Rejecting attachment 212437 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 212437, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
729 (offset 4 lines).
Hunk #33 succeeded at 1739 (offset 4 lines).
Hunk #34 succeeded at 1752 (offset 4 lines).
Hunk #35 succeeded at 1762 (offset 4 lines).
Hunk #36 succeeded at 1771 (offset 4 lines).
1 out of 36 hunks FAILED -- saving rejects to file Source/WebKit/win/WebPreferences.cpp.rej
patching file Source/WebKit/win/WebPreferences.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/18688008

[Brent Fulgham]

Looks like this needs to be rebased. Sorry!

[Patrick R. Gansterer]

Created attachment 215731 [details]
Patch

[EFL EWS Bot]

Comment on attachment 215731 [details]
Patch

Attachment 215731 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/19278113

[WebKit Commit Bot]

Comment on attachment 215731 [details]
Patch

Clearing flags on attachment: 215731

Committed r158434: <http://trac.webkit.org/changeset/158434>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.