Bug 121826 – [EFL] Build failed at ProcessLauncherEfl.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[ChangSeok Oh]

Build command:
./Tools/Scripts/build-webkit --efl --prefix=/usr/local --makeargs="-j8 -Wno-deprecated-declarations" --no-svg --datalist-element

[ 94%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp.o
[ 94%] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Storage/StorageManager.cpp.o
/home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp: In member function ‘void WebKit::ProcessLauncher::launchProcess()’:
/home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70:20: error: ‘AF_UNIX’ was not declared in this scope
/home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70:29: error: ‘SOCK_STREAM’ was not declared in this scope
/home/shivamidow/Projects/WebKit/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:70:52: error: ‘socketpair’ was not declared in this scope
make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2
make: *** [all] Error 2

I guess proper headers are missing.

[ChangSeok Oh]

Created attachment 212435 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 212435 [details]
Patch

In build fix patch case, you don't need to get review. Look at other "Unreviewed build fix patch".

[Gyuyoung Kim]

Comment on attachment 212435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212435&action=review

> Source/WebKit2/ChangeLog:8
> +        Fixed a build failure with adding socket.h.

It would be good if you mention what revision makes a build break.

[ChangSeok Oh]

(In reply to comment #3)
> (From update of attachment 212435 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212435&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        Fixed a build failure with adding socket.h.
> 
> It would be good if you mention what revision makes a build break.

I know. if this happened to gtk port, I would do like that "Unreviewed fix". 
On my side, I'm a just newbie to efl port, so it's hard to know what happens after my last build for efl port almost a year ago.. :p

[Gyuyoung Kim]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 212435 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=212435&action=review
> > 
> > > Source/WebKit2/ChangeLog:8
> > > +        Fixed a build failure with adding socket.h.
> > 
> > It would be good if you mention what revision makes a build break.
> 
> I know. if this happened to gtk port, I would do like that "Unreviewed fix". 
> On my side, I'm a just newbie to efl port, so it's hard to know what happens after my last build for efl port almost a year ago.. :p

Ok, I see. Go ahead.

[WebKit Commit Bot]

Comment on attachment 212435 [details]
Patch

Clearing flags on attachment: 212435

Committed r156333: <http://trac.webkit.org/changeset/156333>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.