As Kling suggested on irc, we need to remove *WebKit* prefix from some isFooValue() functions to apply CSS_VALUE_TYPE_CASTS to all child CSSValue classes.
Created attachment 212419 [details] Patch
Comment on attachment 212419 [details] Patch Unfortunately, we should *WebKit* prefix from class names to apply CSS_VALUE_TYPE_CASTS to WebKitCSS*Value classes. I wonder if I can remove it from WebKitCSSArrayFunctionValue, WebKitCSSMatFunctionValue, WebKitCSSMixFunctionValue, WebKitCSSShaderValue and WebKitCSSSVGDocumentValue. In blink case, it removed the *WebKit* prefix. If we can't, I'd like to land a patch of Bug 121776 at the moment.
Created attachment 212425 [details] Patch
I'm not sure if this removal is acceptable. If not, I'd like to land Bug 121776 for now.
Attachment 212425 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/DerivedSources.cpp', u'Source/WebCore/DerivedSources.make', u'Source/WebCore/DerivedSources.pri', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.order', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSCSSValueCustom.cpp', u'Source/WebCore/bindings/objc/DOMCSS.mm', u'Source/WebCore/css/CSSArrayFunctionValue.cpp', u'Source/WebCore/css/CSSArrayFunctionValue.h', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSFilterValue.cpp', u'Source/WebCore/css/CSSFilterValue.h', u'Source/WebCore/css/CSSFilterValue.idl', u'Source/WebCore/css/CSSMatFunctionValue.cpp', u'Source/WebCore/css/CSSMatFunctionValue.h', u'Source/WebCore/css/CSSMixFunctionValue.cpp', u'Source/WebCore/css/CSSMixFunctionValue.h', u'Source/WebCore/css/CSSMixFunctionValue.idl', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSSVGDocumentValue.cpp', u'Source/WebCore/css/CSSSVGDocumentValue.h', u'Source/WebCore/css/CSSShaderValue.cpp', u'Source/WebCore/css/CSSShaderValue.h', u'Source/WebCore/css/CSSTransformValue.cpp', u'Source/WebCore/css/CSSTransformValue.h', u'Source/WebCore/css/CSSTransformValue.idl', u'Source/WebCore/css/CSSValue.cpp', u'Source/WebCore/css/CSSValue.h', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/TransformFunctions.cpp', u'Source/WebCore/css/TransformFunctions.h', u'Source/WebCore/css/WebKitCSSArrayFunctionValue.cpp', u'Source/WebCore/css/WebKitCSSArrayFunctionValue.h', u'Source/WebCore/css/WebKitCSSFilterValue.cpp', u'Source/WebCore/css/WebKitCSSFilterValue.h', u'Source/WebCore/css/WebKitCSSFilterValue.idl', u'Source/WebCore/css/WebKitCSSMatFunctionValue.cpp', u'Source/WebCore/css/WebKitCSSMatFunctionValue.h', u'Source/WebCore/css/WebKitCSSMixFunctionValue.cpp', u'Source/WebCore/css/WebKitCSSMixFunctionValue.h', u'Source/WebCore/css/WebKitCSSMixFunctionValue.idl', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/css/WebKitCSSShaderValue.cpp', u'Source/WebCore/css/WebKitCSSShaderValue.h', u'Source/WebCore/css/WebKitCSSTransformValue.cpp', u'Source/WebCore/css/WebKitCSSTransformValue.h', u'Source/WebCore/css/WebKitCSSTransformValue.idl', u'Source/WebCore/rendering/style/StylePendingShader.h']" exit_code: 1 Source/WebCore/css/StyleResolver.cpp:125: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/StyleResolver.cpp:133: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/StyleResolver.cpp:155: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/StyleResolver.cpp:182: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/rendering/style/StylePendingShader.h:37: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/js/JSCSSValueCustom.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/js/JSCSSValueCustom.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/js/JSCSSValueCustom.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/js/JSCSSValueCustom.cpp:43: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/CSSValue.cpp:60: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/CSSComputedStyleDeclaration.cpp:64: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/CSSComputedStyleDeclaration.cpp:79: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/CSSComputedStyleDeclaration.cpp:86: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/TransformFunctions.cpp:46: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/DerivedSources.cpp:517: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/css/CSSParser.cpp:88: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 16 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 212425 [details] Patch Attachment 212425 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2092193 New failing tests: js/dom/global-constructors-attributes.html transforms/2d/transform-value-types.html css3/filters/custom/custom-filter-property-computed-style.html css3/filters/custom/custom-filter-mix-bindings.html css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html css3/filters/filter-property-computed-style.html css3/filters/custom/custom-filter-property-parsing.html css3/filters/filter-property-parsing.html platform/mac/fast/dom/wrapper-classes-objc.html
Created attachment 212433 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 212425 [details] Patch Attachment 212425 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1808823 New failing tests: js/dom/global-constructors-attributes.html transforms/2d/transform-value-types.html css3/filters/custom/custom-filter-property-computed-style.html css3/filters/custom/custom-filter-mix-bindings.html css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html css3/filters/filter-property-computed-style.html css3/filters/custom/custom-filter-property-parsing.html css3/filters/filter-property-parsing.html platform/mac/fast/dom/wrapper-classes-objc.html
Created attachment 212436 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 212425 [details] Patch Attachment 212425 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1908397 New failing tests: js/dom/global-constructors-attributes.html transforms/2d/transform-value-types.html css3/filters/custom/custom-filter-property-computed-style.html css3/filters/custom/custom-filter-mix-bindings.html css3/filters/custom-with-at-rule-syntax/parsing-custom-function-valid.html css3/filters/filter-property-computed-style.html css3/filters/custom/custom-filter-property-parsing.html css3/filters/filter-property-parsing.html platform/mac/fast/dom/wrapper-classes-objc.html
Created attachment 212442 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
It looks this removal has lots of regression on mac and other ports. So, I'd like to take a look this later.