RESOLVED FIXED 121812
Move style change analysis code to RenderElement 
https://bugs.webkit.org/show_bug.cgi?id=121812
Summary Move style change analysis code to RenderElement
Antti Koivisto
Reported 2013-09-23 16:58:12 PDT
Text renderers don't need this.
Attachments
patch (27.39 KB, patch)
2013-09-23 17:01 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
another (27.91 KB, patch)
2013-09-23 17:16 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-23 17:01:06 PDT
Created attachment 212407 [details] patch
Andreas Kling
Comment 2 2013-09-23 17:05:36 PDT
Comment on attachment 212407 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=212407&action=review > Source/WebCore/rendering/RenderElement.h:66 > + enum StylePropagationType { PropagateAllChildren, PropagateBlockChildrenOnly }; Shouldn't this be PropagateToAllChildren / PropagateToBlockChildrenOnly?
Early Warning System Bot
Comment 3 2013-09-23 17:11:02 PDT
Comment on attachment 212407 [details] patch Attachment 212407 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1834827
Early Warning System Bot
Comment 4 2013-09-23 17:13:29 PDT
Comment on attachment 212407 [details] patch Attachment 212407 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/2055036
Antti Koivisto
Comment 5 2013-09-23 17:16:58 PDT
Created attachment 212411 [details] another
Antti Koivisto
Comment 6 2013-09-23 17:55:09 PDT
https://trac.webkit.org/r156312
Note You need to log in before you can comment on or make changes to this bug.