Bug 121812 - Move style change analysis code to RenderElement
Summary: Move style change analysis code to RenderElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-23 16:58 PDT by Antti Koivisto
Modified: 2013-09-23 17:55 PDT (History)
7 users (show)

See Also:

Attachments
patch (27.39 KB, patch)
2013-09-23 17:01 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
another (27.91 KB, patch)
2013-09-23 17:16 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-23 16:58:12 PDT 
Text renderers don't need this.
Comment 1 Antti Koivisto 2013-09-23 17:01:06 PDT 
Created attachment 212407 [details]
patch
Comment 2 Andreas Kling 2013-09-23 17:05:36 PDT 
Comment on attachment 212407 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212407&action=review

> Source/WebCore/rendering/RenderElement.h:66
> +    enum StylePropagationType { PropagateAllChildren, PropagateBlockChildrenOnly };

Shouldn't this be PropagateToAllChildren / PropagateToBlockChildrenOnly?
Comment 3 Early Warning System Bot 2013-09-23 17:11:02 PDT 
Comment on attachment 212407 [details]
patch

Attachment 212407 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1834827
Comment 4 Early Warning System Bot 2013-09-23 17:13:29 PDT 
Comment on attachment 212407 [details]
patch

Attachment 212407 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2055036
Comment 5 Antti Koivisto 2013-09-23 17:16:58 PDT 
Created attachment 212411 [details]
another
Comment 6 Antti Koivisto 2013-09-23 17:55:09 PDT 
https://trac.webkit.org/r156312