Bug 121799 - webkitdirs.pm needs --64-bit option for automated Win64 build
Summary: webkitdirs.pm needs --64-bit option for automated Win64 build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-23 12:44 PDT by Alex Christensen
Modified: 2013-11-18 17:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.30 KB, patch)
2013-09-23 12:46 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-09-23 12:44:47 PDT
In order to automate Win64 builds, I need a way to put "|x64" at the end of the Visual Studio configuration.  Visual Studio defaults to Win32, so there's no need to put "|Win32" at the end of the configuration, unless someone thinks we should be that explicit.
Comment 1 Alex Christensen 2013-09-23 12:46:14 PDT
Created attachment 212382 [details]
Patch
Comment 2 Brent Fulgham 2013-09-23 13:07:31 PDT
Comment on attachment 212382 [details]
Patch

Looks great to me.  Let the EWS's run and if it looks good, go ahead and land it.
Comment 3 WebKit Commit Bot 2013-09-23 13:37:27 PDT
Comment on attachment 212382 [details]
Patch

Clearing flags on attachment: 212382

Committed r156290: <http://trac.webkit.org/changeset/156290>
Comment 4 WebKit Commit Bot 2013-09-23 13:37:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2013-11-18 17:29:34 PST
<rdar://problem/15498810>