Bug 121794 - Web Inspector: [CSS Regions] Display CSS Regions flow name in the inspector overlay
Summary: Web Inspector: [CSS Regions] Display CSS Regions flow name in the inspector o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexandru Chiculita
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-23 10:33 PDT by Alexandru Chiculita
Modified: 2013-09-23 13:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch V1 (21.26 KB, patch)
2013-09-23 10:40 PDT, Alexandru Chiculita
joepeck: review+
Details | Formatted Diff | Diff
Patch V2 (21.23 KB, patch)
2013-09-23 13:14 PDT, Alexandru Chiculita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Chiculita 2013-09-23 10:33:16 PDT
Highlight a CSS region node in the web inspector. The overlay should display the name of the flow.
Comment 1 Radar WebKit Bug Importer 2013-09-23 10:33:57 PDT
<rdar://problem/15056045>
Comment 2 Alexandru Chiculita 2013-09-23 10:40:18 PDT
Created attachment 212364 [details]
Patch V1
Comment 3 Joseph Pecoraro 2013-09-23 12:07:53 PDT
Comment on attachment 212364 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=212364&action=review

> Source/WebCore/ChangeLog:12
> +        This patch adds the "-webkit-flow-from" property in the inspector overlay. The region
> +        chain is already displayed with numbers, so it makes sense to have the flow name around when
> +        a CSS region is highlighted.

Nit: At some point we will drop the -webkit- vendor prefix. So including the prefixed property name in the overlay could accidentally be overlooked and become stale. I'd prefer a generic UI String like "Flow: ", or the non-prefixed property in the callout. But I may be over thinking it.

> Source/WebCore/inspector/InspectorOverlayPage.html:41
> +  <span id="flow-name"><br /><span class="css-property">-webkit-flow-from</span>: <span id="flow-name-value"></span>;</span>

Style: Just "<br>" no need for "<br />".

> Source/WebCore/inspector/InspectorOverlayPage.js:270
> +    } else {
> +        flowNameElement.style.display = "none";
> +    }

Style: No braces for single line if/else block.
Comment 4 Alexandru Chiculita 2013-09-23 13:14:04 PDT
Created attachment 212384 [details]
Patch V2
Comment 5 WebKit Commit Bot 2013-09-23 13:44:47 PDT
Comment on attachment 212384 [details]
Patch V2

Clearing flags on attachment: 212384

Committed r156292: <http://trac.webkit.org/changeset/156292>
Comment 6 WebKit Commit Bot 2013-09-23 13:44:50 PDT
All reviewed patches have been landed.  Closing bug.