Bug 121794 – Web Inspector: [CSS Regions] Display CSS Regions flow name in the inspector overlay

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Alexandru Chiculita]

Highlight a CSS region node in the web inspector. The overlay should display the name of the flow.

[Radar WebKit Bug Importer]

<rdar://problem/15056045>

[Alexandru Chiculita]

Created attachment 212364 [details]
Patch V1

[Joseph Pecoraro]

Comment on attachment 212364 [details]
Patch V1

View in context: https://bugs.webkit.org/attachment.cgi?id=212364&action=review

> Source/WebCore/ChangeLog:12
> +        This patch adds the "-webkit-flow-from" property in the inspector overlay. The region
> +        chain is already displayed with numbers, so it makes sense to have the flow name around when
> +        a CSS region is highlighted.

Nit: At some point we will drop the -webkit- vendor prefix. So including the prefixed property name in the overlay could accidentally be overlooked and become stale. I'd prefer a generic UI String like "Flow: ", or the non-prefixed property in the callout. But I may be over thinking it.

> Source/WebCore/inspector/InspectorOverlayPage.html:41
> +  <span id="flow-name"><br /><span class="css-property">-webkit-flow-from</span>: <span id="flow-name-value"></span>;</span>

Style: Just "<br>" no need for "<br />".

> Source/WebCore/inspector/InspectorOverlayPage.js:270
> +    } else {
> +        flowNameElement.style.display = "none";
> +    }

Style: No braces for single line if/else block.

[Alexandru Chiculita]

Created attachment 212384 [details]
Patch V2

[WebKit Commit Bot]

Comment on attachment 212384 [details]
Patch V2

Clearing flags on attachment: 212384

Committed r156292: <http://trac.webkit.org/changeset/156292>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.