Bug 121793 - Buildfix for non Mac platforms with enabled NetworkProcess
Summary: Buildfix for non Mac platforms with enabled NetworkProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 110141
  Show dependency tree / graph
 
Reported: 2013-09-23 10:00 PDT by Csaba Osztrogonác
Modified: 2013-10-10 08:33 PDT (History)
15 users (show)

See Also:

Attachments
Patch (8.63 KB, patch)
2013-09-23 10:23 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (8.85 KB, patch)
2013-09-24 05:48 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-09-23 10:00:08 PDT 
NetworkProcess build is still broken on non Mac platforms because of insufficient ifdefs.
Patch is coming soon.
Comment 1 Csaba Osztrogonác 2013-09-23 10:23:47 PDT 
Created attachment 212361 [details]
Patch
Comment 2 Anders Carlsson 2013-09-23 14:02:50 PDT 
Comment on attachment 212361 [details]
Patch

I don’t think this should be guarded with PLATFORM(MAC), it’s about whether shareable resources are enabled.
Comment 3 Csaba Osztrogonác 2013-09-24 04:56:24 PDT 
(In reply to comment #2)
> (From update of attachment 212361 [details])
> I don’t think this should be guarded with PLATFORM(MAC), it’s about whether shareable resources are enabled.

There isn't any guard for enabling/disabling shareable resources.
Should I add a new ifdef guard for it?

Otherwise I don't understand what is the problem with the
PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 guard?
As I pointed in the changelog, didReceiveResource is only used
in WebKit2/NetworkProcess/AsynchronousNetworkLoaderClient.cpp
inside the same guard. And didCacheResource is only used in 
WebKit2/NetworkProcess/mac/DiskCacheMonitor.mm inside the
same guard.

If PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 condition
is false, all code is unreachable what I proposed to guard.

So what is your suggestion?
Comment 4 Csaba Osztrogonác 2013-09-24 05:48:13 PDT 
Created attachment 212454 [details]
Patch

Let's try to add a new guard: ENABLE(SHAREABLE_RESOURCE) and enable it on Mac by default.
Comment 5 Csaba Osztrogonác 2013-09-27 04:17:14 PDT 
(In reply to comment #4)
> Created an attachment (id=212454) [details]
> Patch
> 
> Let's try to add a new guard: ENABLE(SHAREABLE_RESOURCE) and enable it on Mac by default.

Anders, do you mean this kind of guarding?
Comment 6 Csaba Osztrogonác 2013-09-30 06:47:31 PDT 
ping?
Comment 7 Csaba Osztrogonác 2013-10-07 07:55:23 PDT 
Anders, could you review this new patch please?
Comment 8 Csaba Osztrogonác 2013-10-10 08:04:26 PDT 
(In reply to comment #7)
> Anders, could you review this new patch please?
ping?

I fixed immediately what you asked 2 weeks before. :(
Comment 9 Csaba Osztrogonác 2013-10-10 08:07:34 PDT 
Adding more WK2 owner, maybe somebody have a little bit time for review.
Comment 10 WebKit Commit Bot 2013-10-10 08:33:32 PDT 
Comment on attachment 212454 [details]
Patch

Clearing flags on attachment: 212454

Committed r157225: <http://trac.webkit.org/changeset/157225>
Comment 11 WebKit Commit Bot 2013-10-10 08:33:35 PDT 
All reviewed patches have been landed.  Closing bug.