Bug 121792 - [iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and shouldRespectImageOrientation as appropriate
Summary: [iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} an...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-23 09:56 PDT by Daniel Bates
Modified: 2013-09-24 10:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.68 KB, patch)
2013-09-23 09:58 PDT, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2013-09-23 17:06 PDT, Daniel Bates 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2013-09-23 09:56:08 PDT 
In contrast to other platform, we want to disable mediaPlaybackAllowsInline, and enable mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default on iOS.
Comment 1 Daniel Bates 2013-09-23 09:58:06 PDT 
Created attachment 212359 [details]
Patch
Comment 2 Darin Adler 2013-09-23 10:00:56 PDT 
Comment on attachment 212359 [details]
Patch

I don’t think the ForPlatform suffixes add much clarity. I also think this approach is awkward. But seems OK.
Comment 3 Daniel Bates 2013-09-23 10:59:37 PDT 
(In reply to comment #2)
> (From update of attachment 212359 [details])
> I don’t think the ForPlatform suffixes add much clarity. I also think this approach is awkward. But seems OK.

I am open to ideas/suggestions on a better approach. For now, I'll drop the "ForPlatform" suffixes.
Comment 4 Daniel Bates 2013-09-23 17:06:21 PDT 
Created attachment 212410 [details]
Patch

I've updated the patch to add constants whose definition is conditioned on whether we are building for iOS instead of adding functions. I choose this to approach to help make the code in Settings.cpp more readable by minimizing both the number of added #ifdef guards and lines of code. Let me know if there is a better way to define an iOS-specific default value for a setting.
Comment 5 Daniel Bates 2013-09-24 10:11:28 PDT 
Committed r156337: <http://trac.webkit.org/changeset/156337>