Bug 121790 - [Qt] RepaintRequested signal sometimes not emitted
Summary: [Qt] RepaintRequested signal sometimes not emitted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-23 07:54 PDT by Allan Sandfeld Jensen
Modified: 2013-09-24 07:09 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.88 KB, patch)
2013-09-23 07:56 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2013-09-23 08:23 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-09-23 07:54:50 PDT
If updates are triggered through PageClient::repaintViewport() we do not emit the QWebPage::repaintRequested signal since this is only emitted from ChromeClientQt::invalidateContentsAndRootView.
Comment 1 Allan Sandfeld Jensen 2013-09-23 07:56:18 PDT
Created attachment 212350 [details]
Patch
Comment 2 Early Warning System Bot 2013-09-23 08:02:48 PDT
Comment on attachment 212350 [details]
Patch

Attachment 212350 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1799491
Comment 3 Allan Sandfeld Jensen 2013-09-23 08:23:08 PDT
Created attachment 212352 [details]
Patch
Comment 4 WebKit Commit Bot 2013-09-24 07:09:29 PDT
Comment on attachment 212352 [details]
Patch

Clearing flags on attachment: 212352

Committed r156329: <http://trac.webkit.org/changeset/156329>
Comment 5 WebKit Commit Bot 2013-09-24 07:09:31 PDT
All reviewed patches have been landed.  Closing bug.