Bug 121784 - Rename RenderObject::first/lastChild to RenderObject::first/lastChildSlow
Summary: Rename RenderObject::first/lastChild to RenderObject::first/lastChildSlow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-23 05:13 PDT by Antti Koivisto
Modified: 2013-09-23 12:31 PDT (History)
3 users (show)

See Also:

Attachments
patch (49.27 KB, patch)
2013-09-23 10:53 PDT, Antti Koivisto 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
another (49.27 KB, patch)
2013-09-23 11:06 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
yet another (50.83 KB, patch)
2013-09-23 11:24 PDT, Antti Koivisto 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
yet yet another (51.70 KB, patch)
2013-09-23 11:41 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-23 05:13:39 PDT 
This will make it obvious in code where typing should be tightened.
Comment 1 Antti Koivisto 2013-09-23 10:53:27 PDT 
Created attachment 212366 [details]
patch
Comment 2 Early Warning System Bot 2013-09-23 10:59:55 PDT 
Comment on attachment 212366 [details]
patch

Attachment 212366 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2053161
Comment 3 Andreas Kling 2013-09-23 11:04:08 PDT 
Comment on attachment 212366 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212366&action=review

I guess we can and should tighten all these things, but here's some whining anyway:

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:328
> -    return renderer->firstChild() && renderer->firstChild()->isInlineElementContinuation();
> +    return renderer->firstChildSlow() && renderer->firstChildSlow()->isInlineElementContinuation();

Should we cache it in a local here to avoid double virtual dispatch?

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:370
> -    return renderer->lastChild() && isInlineWithContinuation(renderer->lastChild());
> +    return renderer->lastChildSlow() && isInlineWithContinuation(renderer->lastChildSlow());

And here.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:464
> -            if (firstChild == parent->firstChild())
> +            if (firstChild == parent->firstChildSlow())
>                  break;
> -            firstChild = parent->firstChild();
> +            firstChild = parent->firstChildSlow();

Also here.

> Source/WebCore/dom/ContainerNode.cpp:898
> -        if (o->firstChild())
> -            o = o->firstChild();
> +        if (o->firstChildSlow())
> +            o = o->firstChildSlow();

etc.

> Source/WebCore/dom/ContainerNode.cpp:958
> -        if (o->lastChild())
> -            o = o->lastChild();
> +        if (o->lastChildSlow())
> +            o = o->lastChildSlow();

etc.

> Source/WebCore/rendering/RenderBlock.cpp:1081
> -    if (prev && prev->firstChild() && prev->firstChild()->isInline() && prev->firstChild()->isRunIn())
> +    if (prev && prev->firstChildSlow() && prev->firstChildSlow()->isInline() && prev->firstChildSlow()->isRunIn())

Oh here.
Comment 4 Early Warning System Bot 2013-09-23 11:05:24 PDT 
Comment on attachment 212366 [details]
patch

Attachment 212366 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2053164
Comment 5 Antti Koivisto 2013-09-23 11:06:07 PDT 
Created attachment 212368 [details]
another
Comment 6 Andreas Kling 2013-09-23 11:07:20 PDT 
Comment on attachment 212368 [details]
another

r=me
Comment 7 Early Warning System Bot 2013-09-23 11:12:43 PDT 
Comment on attachment 212368 [details]
another

Attachment 212368 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2118005
Comment 8 Early Warning System Bot 2013-09-23 11:13:29 PDT 
Comment on attachment 212368 [details]
another

Attachment 212368 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2114008
Comment 9 Antti Koivisto 2013-09-23 11:24:04 PDT 
Created attachment 212370 [details]
yet another
Comment 10 Early Warning System Bot 2013-09-23 11:33:45 PDT 
Comment on attachment 212370 [details]
yet another

Attachment 212370 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2123008
Comment 11 Early Warning System Bot 2013-09-23 11:35:42 PDT 
Comment on attachment 212370 [details]
yet another

Attachment 212370 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1903241
Comment 12 Antti Koivisto 2013-09-23 11:41:16 PDT 
Created attachment 212374 [details]
yet yet another
Comment 13 Antti Koivisto 2013-09-23 12:31:37 PDT 
https://trac.webkit.org/r156285 (accessibility tests and gtk build fixed)