Bug 121768 - CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes
Summary: CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elemen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-22 14:01 PDT by Sam Weinig
Modified: 2013-10-07 06:02 PDT (History)
8 users (show)

See Also:

Attachments
Patch (27.75 KB, patch)
2013-09-22 14:07 PDT, Sam Weinig 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-22 14:01:29 PDT 
CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes
Comment 1 Sam Weinig 2013-09-22 14:07:52 PDT 
Created attachment 212306 [details]
Patch
Comment 2 Andreas Kling 2013-09-22 14:15:26 PDT 
Comment on attachment 212306 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212306&action=review

r=me

> Source/WebCore/rendering/RenderNamedFlowThread.cpp:556
> +static bool isContainedInElements(Vector<Element*> others, Element* element)

'others' should be a const reference, we are making a silly copy here.
Comment 3 Sam Weinig 2013-09-22 14:22:32 PDT 
Committed r156250: <http://trac.webkit.org/changeset/156250>
Comment 4 Mihai Maerean 2013-10-07 06:02:57 PDT 
According to the CSS Regions Specification (http://dev.w3.org/csswg/css-regions/#the-flow-into-property), you can collect nodes (not just elements) into a flow thread.

This bug is invalid.

The named flow thread below will only contain a text node, the child of the div marked .content.

<style>
.content {
  flow-into:flow content;
}
.region {
  flow-from:flow;
}
</style>
<div class="content">some text</div>
<div class="region"></div>