Bug 121751 - Event and EventTarget interfaces don't need to be store as AtomicStrings
Summary: Event and EventTarget interfaces don't need to be store as AtomicStrings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-21 12:51 PDT by Sam Weinig
Modified: 2013-09-24 11:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (118.34 KB, patch)
2013-09-21 12:55 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (119.68 KB, patch)
2013-09-21 13:31 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (119.71 KB, patch)
2013-09-21 13:44 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (130.32 KB, patch)
2013-09-21 15:14 PDT, Sam Weinig 		sam: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-09-21 12:51:07 PDT 
Event and EventTarget interfaces don't need to be store as AtomicStrings
Comment 1 Sam Weinig 2013-09-21 12:55:21 PDT 
Created attachment 212279 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-21 12:56:52 PDT 
Attachment 212279 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeyNeededEvent.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeyNeededEvent.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.h', u'Source/WebCore/Modules/filesystem/FileWriter.h', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp', u'Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h', u'Source/WebCore/Modules/indieui/UIRequestEvent.cpp', u'Source/WebCore/Modules/indieui/UIRequestEvent.h', u'Source/WebCore/Modules/mediasource/MediaSource.cpp', u'Source/WebCore/Modules/mediasource/MediaSource.h', u'Source/WebCore/Modules/mediasource/SourceBuffer.cpp', u'Source/WebCore/Modules/mediasource/SourceBuffer.h', u'Source/WebCore/Modules/mediasource/SourceBufferList.cpp', u'Source/WebCore/Modules/mediasource/SourceBufferList.h', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.cpp', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.h', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.cpp', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.h', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.h', u'Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamEvent.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.h', u'Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h', u'Source/WebCore/Modules/mediastream/RTCDataChannel.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannel.h', u'Source/WebCore/Modules/mediastream/RTCDataChannelEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannelEvent.h', u'Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.h', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.h', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Modules/notifications/Notification.h', u'Source/WebCore/Modules/speech/SpeechSynthesisEvent.h', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.h', u'Source/WebCore/Modules/webaudio/AudioNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNode.h', u'Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp', u'Source/WebCore/Modules/webaudio/AudioProcessingEvent.h', u'Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h', u'Source/WebCore/Modules/websockets/CloseEvent.h', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocket.h', u'Source/WebCore/bindings/js/JSErrorHandler.cpp', u'Source/WebCore/bindings/js/JSEventCustom.cpp', u'Source/WebCore/bindings/js/JSEventTargetCustom.cpp', u'Source/WebCore/bindings/objc/DOMEvents.mm', u'Source/WebCore/css/CSSFontFaceLoadEvent.cpp', u'Source/WebCore/css/CSSFontFaceLoadEvent.h', u'Source/WebCore/css/FontLoader.h', u'Source/WebCore/dom/BeforeLoadEvent.h', u'Source/WebCore/dom/BeforeTextInsertedEvent.cpp', u'Source/WebCore/dom/BeforeTextInsertedEvent.h', u'Source/WebCore/dom/BeforeUnloadEvent.h', u'Source/WebCore/dom/ClipboardEvent.cpp', u'Source/WebCore/dom/ClipboardEvent.h', u'Source/WebCore/dom/CompositionEvent.cpp', u'Source/WebCore/dom/CompositionEvent.h', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/DeviceMotionEvent.cpp', u'Source/WebCore/dom/DeviceMotionEvent.h', u'Source/WebCore/dom/DeviceOrientationEvent.cpp', u'Source/WebCore/dom/DeviceOrientationEvent.h', u'Source/WebCore/dom/ErrorEvent.cpp', u'Source/WebCore/dom/ErrorEvent.h', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/EventNames.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/FocusEvent.cpp', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/HashChangeEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/MessagePort.cpp', u'Source/WebCore/dom/MessagePort.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MutationEvent.cpp', u'Source/WebCore/dom/MutationEvent.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/OverflowEvent.cpp', u'Source/WebCore/dom/OverflowEvent.h', u'Source/WebCore/dom/PageTransitionEvent.cpp', u'Source/WebCore/dom/PageTransitionEvent.h', u'Source/WebCore/dom/PopStateEvent.cpp', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ProgressEvent.cpp', u'Source/WebCore/dom/ProgressEvent.h', u'Source/WebCore/dom/SecurityPolicyViolationEvent.h', u'Source/WebCore/dom/TextEvent.cpp', u'Source/WebCore/dom/TextEvent.h', u'Source/WebCore/dom/TransitionEvent.cpp', u'Source/WebCore/dom/TransitionEvent.h', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/WebKitAnimationEvent.cpp', u'Source/WebCore/dom/WebKitAnimationEvent.h', u'Source/WebCore/dom/WebKitNamedFlow.cpp', u'Source/WebCore/dom/WebKitNamedFlow.h', u'Source/WebCore/dom/WebKitTransitionEvent.cpp', u'Source/WebCore/dom/WebKitTransitionEvent.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/fileapi/FileReader.cpp', u'Source/WebCore/fileapi/FileReader.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/MediaController.h', u'Source/WebCore/html/MediaKeyEvent.cpp', u'Source/WebCore/html/MediaKeyEvent.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/canvas/WebGLContextEvent.cpp', u'Source/WebCore/html/canvas/WebGLContextEvent.h', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SpinButtonElement.cpp', u'Source/WebCore/html/track/AudioTrackList.cpp', u'Source/WebCore/html/track/AudioTrackList.h', u'Source/WebCore/html/track/TextTrack.cpp', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/html/track/TextTrackList.cpp', u'Source/WebCore/html/track/TextTrackList.h', u'Source/WebCore/html/track/TrackEvent.cpp', u'Source/WebCore/html/track/TrackEvent.h', u'Source/WebCore/html/track/TrackListBase.h', u'Source/WebCore/html/track/VideoTrackList.cpp', u'Source/WebCore/html/track/VideoTrackList.h', u'Source/WebCore/loader/appcache/DOMApplicationCache.cpp', u'Source/WebCore/loader/appcache/DOMApplicationCache.h', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/EventSource.h', u'Source/WebCore/page/Performance.cpp', u'Source/WebCore/page/Performance.h', u'Source/WebCore/page/SpeechInputEvent.h', u'Source/WebCore/storage/StorageEvent.cpp', u'Source/WebCore/storage/StorageEvent.h', u'Source/WebCore/svg/SVGElementInstance.cpp', u'Source/WebCore/svg/SVGElementInstance.h', u'Source/WebCore/svg/SVGZoomEvent.cpp', u'Source/WebCore/svg/SVGZoomEvent.h', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.h', u'Source/WebCore/workers/SharedWorker.cpp', u'Source/WebCore/workers/SharedWorker.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/SharedWorkerGlobalScope.h', u'Source/WebCore/workers/Worker.cpp', u'Source/WebCore/workers/Worker.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLHttpRequest.h', u'Source/WebCore/xml/XMLHttpRequestProgressEvent.h', u'Source/WebCore/xml/XMLHttpRequestUpload.cpp', u'Source/WebCore/xml/XMLHttpRequestUpload.h']" exit_code: 1
Source/WebCore/dom/EventTarget.h:105:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:107:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/dom/EventNames.h:277:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/dom/EventNames.h:279:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 5 in 182 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-09-21 12:58:18 PDT 
Comment on attachment 212279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212279&action=review

r=me

> Source/WebCore/dom/EventNames.h:305
> +        names.reserveCapacity(4);
> +        names.append(touchstartEvent);
> +        names.append(touchmoveEvent);
> +        names.append(touchendEvent);
> +        names.append(touchcancelEvent);

Since you are touching these lines, you might as well make it reserveInitialCapacity() and uncheckedAppend().
Comment 4 Early Warning System Bot 2013-09-21 13:04:47 PDT 
Comment on attachment 212279 [details]
Patch

Attachment 212279 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/2011083
Comment 5 Early Warning System Bot 2013-09-21 13:05:14 PDT 
Comment on attachment 212279 [details]
Patch

Attachment 212279 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/2011082
Comment 6 EFL EWS Bot 2013-09-21 13:20:13 PDT 
Comment on attachment 212279 [details]
Patch

Attachment 212279 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1967321
Comment 7 EFL EWS Bot 2013-09-21 13:27:02 PDT 
Comment on attachment 212279 [details]
Patch

Attachment 212279 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1803426
Comment 8 Sam Weinig 2013-09-21 13:31:20 PDT 
Created attachment 212282 [details]
Patch
Comment 9 Sam Weinig 2013-09-21 13:44:35 PDT 
Created attachment 212283 [details]
Patch
Comment 10 WebKit Commit Bot 2013-09-21 13:47:33 PDT 
Attachment 212283 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/battery/BatteryManager.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeyNeededEvent.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeyNeededEvent.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.h', u'Source/WebCore/Modules/filesystem/FileWriter.h', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp', u'Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h', u'Source/WebCore/Modules/indieui/UIRequestEvent.cpp', u'Source/WebCore/Modules/indieui/UIRequestEvent.h', u'Source/WebCore/Modules/mediasource/MediaSource.cpp', u'Source/WebCore/Modules/mediasource/MediaSource.h', u'Source/WebCore/Modules/mediasource/SourceBuffer.cpp', u'Source/WebCore/Modules/mediasource/SourceBuffer.h', u'Source/WebCore/Modules/mediasource/SourceBufferList.cpp', u'Source/WebCore/Modules/mediasource/SourceBufferList.h', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.cpp', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.h', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.cpp', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.h', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.h', u'Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamEvent.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.h', u'Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h', u'Source/WebCore/Modules/mediastream/RTCDataChannel.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannel.h', u'Source/WebCore/Modules/mediastream/RTCDataChannelEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannelEvent.h', u'Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.h', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.h', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Modules/notifications/Notification.h', u'Source/WebCore/Modules/speech/SpeechSynthesisEvent.h', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.h', u'Source/WebCore/Modules/webaudio/AudioNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNode.h', u'Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp', u'Source/WebCore/Modules/webaudio/AudioProcessingEvent.h', u'Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h', u'Source/WebCore/Modules/websockets/CloseEvent.h', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocket.h', u'Source/WebCore/bindings/js/JSErrorHandler.cpp', u'Source/WebCore/bindings/js/JSEventCustom.cpp', u'Source/WebCore/bindings/js/JSEventTargetCustom.cpp', u'Source/WebCore/bindings/objc/DOMEvents.mm', u'Source/WebCore/css/CSSFontFaceLoadEvent.cpp', u'Source/WebCore/css/CSSFontFaceLoadEvent.h', u'Source/WebCore/css/FontLoader.h', u'Source/WebCore/dom/BeforeLoadEvent.h', u'Source/WebCore/dom/BeforeTextInsertedEvent.cpp', u'Source/WebCore/dom/BeforeTextInsertedEvent.h', u'Source/WebCore/dom/BeforeUnloadEvent.h', u'Source/WebCore/dom/ClipboardEvent.cpp', u'Source/WebCore/dom/ClipboardEvent.h', u'Source/WebCore/dom/CompositionEvent.cpp', u'Source/WebCore/dom/CompositionEvent.h', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/DeviceMotionEvent.cpp', u'Source/WebCore/dom/DeviceMotionEvent.h', u'Source/WebCore/dom/DeviceOrientationEvent.cpp', u'Source/WebCore/dom/DeviceOrientationEvent.h', u'Source/WebCore/dom/ErrorEvent.cpp', u'Source/WebCore/dom/ErrorEvent.h', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/EventNames.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/FocusEvent.cpp', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/HashChangeEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/MessagePort.cpp', u'Source/WebCore/dom/MessagePort.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MutationEvent.cpp', u'Source/WebCore/dom/MutationEvent.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/OverflowEvent.cpp', u'Source/WebCore/dom/OverflowEvent.h', u'Source/WebCore/dom/PageTransitionEvent.cpp', u'Source/WebCore/dom/PageTransitionEvent.h', u'Source/WebCore/dom/PopStateEvent.cpp', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ProgressEvent.cpp', u'Source/WebCore/dom/ProgressEvent.h', u'Source/WebCore/dom/SecurityPolicyViolationEvent.h', u'Source/WebCore/dom/TextEvent.cpp', u'Source/WebCore/dom/TextEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/TouchEvent.h', u'Source/WebCore/dom/TransitionEvent.cpp', u'Source/WebCore/dom/TransitionEvent.h', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/WebKitAnimationEvent.cpp', u'Source/WebCore/dom/WebKitAnimationEvent.h', u'Source/WebCore/dom/WebKitNamedFlow.cpp', u'Source/WebCore/dom/WebKitNamedFlow.h', u'Source/WebCore/dom/WebKitTransitionEvent.cpp', u'Source/WebCore/dom/WebKitTransitionEvent.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/fileapi/FileReader.cpp', u'Source/WebCore/fileapi/FileReader.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/MediaController.h', u'Source/WebCore/html/MediaKeyEvent.cpp', u'Source/WebCore/html/MediaKeyEvent.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/canvas/WebGLContextEvent.cpp', u'Source/WebCore/html/canvas/WebGLContextEvent.h', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SpinButtonElement.cpp', u'Source/WebCore/html/track/AudioTrackList.cpp', u'Source/WebCore/html/track/AudioTrackList.h', u'Source/WebCore/html/track/TextTrack.cpp', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/html/track/TextTrackList.cpp', u'Source/WebCore/html/track/TextTrackList.h', u'Source/WebCore/html/track/TrackEvent.cpp', u'Source/WebCore/html/track/TrackEvent.h', u'Source/WebCore/html/track/TrackListBase.h', u'Source/WebCore/html/track/VideoTrackList.cpp', u'Source/WebCore/html/track/VideoTrackList.h', u'Source/WebCore/loader/appcache/DOMApplicationCache.cpp', u'Source/WebCore/loader/appcache/DOMApplicationCache.h', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/EventSource.h', u'Source/WebCore/page/Performance.cpp', u'Source/WebCore/page/Performance.h', u'Source/WebCore/page/SpeechInputEvent.h', u'Source/WebCore/storage/StorageEvent.cpp', u'Source/WebCore/storage/StorageEvent.h', u'Source/WebCore/svg/SVGElementInstance.cpp', u'Source/WebCore/svg/SVGElementInstance.h', u'Source/WebCore/svg/SVGZoomEvent.cpp', u'Source/WebCore/svg/SVGZoomEvent.h', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.h', u'Source/WebCore/workers/SharedWorker.cpp', u'Source/WebCore/workers/SharedWorker.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/SharedWorkerGlobalScope.h', u'Source/WebCore/workers/Worker.cpp', u'Source/WebCore/workers/Worker.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLHttpRequest.h', u'Source/WebCore/xml/XMLHttpRequestProgressEvent.h', u'Source/WebCore/xml/XMLHttpRequestUpload.cpp', u'Source/WebCore/xml/XMLHttpRequestUpload.h']" exit_code: 1
Source/WebCore/dom/EventTarget.h:105:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:107:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/dom/EventNames.h:277:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/dom/EventNames.h:279:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 5 in 185 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 11 EFL EWS Bot 2013-09-21 14:23:48 PDT 
Comment on attachment 212283 [details]
Patch

Attachment 212283 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1966376
Comment 12 EFL EWS Bot 2013-09-21 15:06:41 PDT 
Comment on attachment 212283 [details]
Patch

Attachment 212283 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2011106
Comment 13 Sam Weinig 2013-09-21 15:14:22 PDT 
Created attachment 212286 [details]
Patch
Comment 14 WebKit Commit Bot 2013-09-21 15:15:50 PDT 
Attachment 212286 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/battery/BatteryManager.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeyMessageEvent.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeyNeededEvent.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeyNeededEvent.h', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.cpp', u'Source/WebCore/Modules/encryptedmedia/MediaKeySession.h', u'Source/WebCore/Modules/filesystem/FileWriter.cpp', u'Source/WebCore/Modules/filesystem/FileWriter.h', u'Source/WebCore/Modules/indexeddb/IDBDatabase.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabase.h', u'Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h', u'Source/WebCore/Modules/indexeddb/IDBRequest.cpp', u'Source/WebCore/Modules/indexeddb/IDBRequest.h', u'Source/WebCore/Modules/indexeddb/IDBTransaction.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransaction.h', u'Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.cpp', u'Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.h', u'Source/WebCore/Modules/indieui/UIRequestEvent.cpp', u'Source/WebCore/Modules/indieui/UIRequestEvent.h', u'Source/WebCore/Modules/mediasource/MediaSource.cpp', u'Source/WebCore/Modules/mediasource/MediaSource.h', u'Source/WebCore/Modules/mediasource/SourceBuffer.cpp', u'Source/WebCore/Modules/mediasource/SourceBuffer.h', u'Source/WebCore/Modules/mediasource/SourceBufferList.cpp', u'Source/WebCore/Modules/mediasource/SourceBufferList.h', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.cpp', u'Source/WebCore/Modules/mediasource/WebKitMediaSource.h', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.cpp', u'Source/WebCore/Modules/mediasource/WebKitSourceBufferList.h', u'Source/WebCore/Modules/mediastream/MediaStream.cpp', u'Source/WebCore/Modules/mediastream/MediaStream.h', u'Source/WebCore/Modules/mediastream/MediaStreamEvent.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamEvent.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamTrack.h', u'Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.cpp', u'Source/WebCore/Modules/mediastream/MediaStreamTrackEvent.h', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFSender.h', u'Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCDTMFToneChangeEvent.h', u'Source/WebCore/Modules/mediastream/RTCDataChannel.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannel.h', u'Source/WebCore/Modules/mediastream/RTCDataChannelEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCDataChannelEvent.h', u'Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.cpp', u'Source/WebCore/Modules/mediastream/RTCIceCandidateEvent.h', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.h', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.cpp', u'Source/WebCore/Modules/networkinfo/NetworkInfoConnection.h', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Modules/notifications/Notification.h', u'Source/WebCore/Modules/proximity/DeviceProximityEvent.h', u'Source/WebCore/Modules/speech/SpeechRecognition.cpp', u'Source/WebCore/Modules/speech/SpeechRecognition.h', u'Source/WebCore/Modules/speech/SpeechRecognitionError.cpp', u'Source/WebCore/Modules/speech/SpeechRecognitionError.h', u'Source/WebCore/Modules/speech/SpeechRecognitionEvent.cpp', u'Source/WebCore/Modules/speech/SpeechRecognitionEvent.h', u'Source/WebCore/Modules/speech/SpeechSynthesisEvent.h', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.cpp', u'Source/WebCore/Modules/speech/SpeechSynthesisUtterance.h', u'Source/WebCore/Modules/webaudio/AudioContext.cpp', u'Source/WebCore/Modules/webaudio/AudioContext.h', u'Source/WebCore/Modules/webaudio/AudioNode.cpp', u'Source/WebCore/Modules/webaudio/AudioNode.h', u'Source/WebCore/Modules/webaudio/AudioProcessingEvent.cpp', u'Source/WebCore/Modules/webaudio/AudioProcessingEvent.h', u'Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.cpp', u'Source/WebCore/Modules/webaudio/OfflineAudioCompletionEvent.h', u'Source/WebCore/Modules/websockets/CloseEvent.h', u'Source/WebCore/Modules/websockets/WebSocket.cpp', u'Source/WebCore/Modules/websockets/WebSocket.h', u'Source/WebCore/bindings/js/JSErrorHandler.cpp', u'Source/WebCore/bindings/js/JSEventCustom.cpp', u'Source/WebCore/bindings/js/JSEventTargetCustom.cpp', u'Source/WebCore/bindings/objc/DOMEvents.mm', u'Source/WebCore/css/CSSFontFaceLoadEvent.cpp', u'Source/WebCore/css/CSSFontFaceLoadEvent.h', u'Source/WebCore/css/FontLoader.cpp', u'Source/WebCore/css/FontLoader.h', u'Source/WebCore/dom/BeforeLoadEvent.h', u'Source/WebCore/dom/BeforeTextInsertedEvent.cpp', u'Source/WebCore/dom/BeforeTextInsertedEvent.h', u'Source/WebCore/dom/BeforeUnloadEvent.h', u'Source/WebCore/dom/ClipboardEvent.cpp', u'Source/WebCore/dom/ClipboardEvent.h', u'Source/WebCore/dom/CompositionEvent.cpp', u'Source/WebCore/dom/CompositionEvent.h', u'Source/WebCore/dom/CustomEvent.cpp', u'Source/WebCore/dom/CustomEvent.h', u'Source/WebCore/dom/DeviceMotionEvent.cpp', u'Source/WebCore/dom/DeviceMotionEvent.h', u'Source/WebCore/dom/DeviceOrientationEvent.cpp', u'Source/WebCore/dom/DeviceOrientationEvent.h', u'Source/WebCore/dom/ErrorEvent.cpp', u'Source/WebCore/dom/ErrorEvent.h', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/EventNames.cpp', u'Source/WebCore/dom/EventNames.h', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/FocusEvent.cpp', u'Source/WebCore/dom/FocusEvent.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/HashChangeEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MessageEvent.cpp', u'Source/WebCore/dom/MessageEvent.h', u'Source/WebCore/dom/MessagePort.cpp', u'Source/WebCore/dom/MessagePort.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MutationEvent.cpp', u'Source/WebCore/dom/MutationEvent.h', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/OverflowEvent.cpp', u'Source/WebCore/dom/OverflowEvent.h', u'Source/WebCore/dom/PageTransitionEvent.cpp', u'Source/WebCore/dom/PageTransitionEvent.h', u'Source/WebCore/dom/PopStateEvent.cpp', u'Source/WebCore/dom/PopStateEvent.h', u'Source/WebCore/dom/ProgressEvent.cpp', u'Source/WebCore/dom/ProgressEvent.h', u'Source/WebCore/dom/SecurityPolicyViolationEvent.h', u'Source/WebCore/dom/TextEvent.cpp', u'Source/WebCore/dom/TextEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/TouchEvent.h', u'Source/WebCore/dom/TransitionEvent.cpp', u'Source/WebCore/dom/TransitionEvent.h', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/WebKitAnimationEvent.cpp', u'Source/WebCore/dom/WebKitAnimationEvent.h', u'Source/WebCore/dom/WebKitNamedFlow.cpp', u'Source/WebCore/dom/WebKitNamedFlow.h', u'Source/WebCore/dom/WebKitTransitionEvent.cpp', u'Source/WebCore/dom/WebKitTransitionEvent.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/fileapi/FileReader.cpp', u'Source/WebCore/fileapi/FileReader.h', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/MediaController.cpp', u'Source/WebCore/html/MediaController.h', u'Source/WebCore/html/MediaKeyEvent.cpp', u'Source/WebCore/html/MediaKeyEvent.h', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/canvas/WebGLContextEvent.cpp', u'Source/WebCore/html/canvas/WebGLContextEvent.h', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SpinButtonElement.cpp', u'Source/WebCore/html/track/AudioTrackList.cpp', u'Source/WebCore/html/track/AudioTrackList.h', u'Source/WebCore/html/track/TextTrack.cpp', u'Source/WebCore/html/track/TextTrack.h', u'Source/WebCore/html/track/TextTrackCue.cpp', u'Source/WebCore/html/track/TextTrackCue.h', u'Source/WebCore/html/track/TextTrackList.cpp', u'Source/WebCore/html/track/TextTrackList.h', u'Source/WebCore/html/track/TrackEvent.cpp', u'Source/WebCore/html/track/TrackEvent.h', u'Source/WebCore/html/track/TrackListBase.h', u'Source/WebCore/html/track/VideoTrackList.cpp', u'Source/WebCore/html/track/VideoTrackList.h', u'Source/WebCore/loader/appcache/DOMApplicationCache.cpp', u'Source/WebCore/loader/appcache/DOMApplicationCache.h', u'Source/WebCore/page/DOMWindow.cpp', u'Source/WebCore/page/DOMWindow.h', u'Source/WebCore/page/EventSource.cpp', u'Source/WebCore/page/EventSource.h', u'Source/WebCore/page/Performance.cpp', u'Source/WebCore/page/Performance.h', u'Source/WebCore/page/SpeechInputEvent.cpp', u'Source/WebCore/page/SpeechInputEvent.h', u'Source/WebCore/storage/StorageEvent.cpp', u'Source/WebCore/storage/StorageEvent.h', u'Source/WebCore/svg/SVGElementInstance.cpp', u'Source/WebCore/svg/SVGElementInstance.h', u'Source/WebCore/svg/SVGZoomEvent.cpp', u'Source/WebCore/svg/SVGZoomEvent.h', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.cpp', u'Source/WebCore/workers/DedicatedWorkerGlobalScope.h', u'Source/WebCore/workers/SharedWorker.cpp', u'Source/WebCore/workers/SharedWorker.h', u'Source/WebCore/workers/SharedWorkerGlobalScope.cpp', u'Source/WebCore/workers/SharedWorkerGlobalScope.h', u'Source/WebCore/workers/Worker.cpp', u'Source/WebCore/workers/Worker.h', u'Source/WebCore/xml/XMLHttpRequest.cpp', u'Source/WebCore/xml/XMLHttpRequest.h', u'Source/WebCore/xml/XMLHttpRequestProgressEvent.h', u'Source/WebCore/xml/XMLHttpRequestUpload.cpp', u'Source/WebCore/xml/XMLHttpRequestUpload.h']" exit_code: 1
Source/WebCore/dom/EventTarget.h:105:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/dom/EventTarget.h:107:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/dom/EventNames.h:277:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Source/WebCore/dom/EventNames.h:279:  preprocessor directives (e.g., #ifdef, #define, #import) should never be indented.  [whitespace/indent] [4]
Total errors found: 5 in 202 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 EFL EWS Bot 2013-09-21 15:46:46 PDT 
Comment on attachment 212286 [details]
Patch

Attachment 212286 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1967355
Comment 16 Build Bot 2013-09-21 20:00:22 PDT 
Comment on attachment 212286 [details]
Patch

Attachment 212286 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1828316
Comment 17 Jon Lee 2013-09-22 13:59:25 PDT 
This broke the Windows builders: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/52511
Comment 18 Daniel Bates 2013-09-24 11:35:26 PDT 
The patch for this bug was committed in <http://trac.webkit.org/changeset/156241>.
Comment 19 Daniel Bates 2013-09-24 11:37:22 PDT 
Build fixes were committed in:

<http://trac.webkit.org/changeset/156248>
<http://trac.webkit.org/changeset/156249>