Bug 121745 - Don't bloat Obj-C bindings with inlined attribute retrieval.
Summary: Don't bloat Obj-C bindings with inlined attribute retrieval.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-09-21 09:53 PDT by Andreas Kling
Modified: 2013-09-21 20:30 PDT (History)
4 users (show)

See Also:

Patch idea (1.59 KB, patch)
2013-09-21 09:54 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-21 09:53:30 PDT
fastGetAttribute() is overkill here.
Comment 1 Andreas Kling 2013-09-21 09:54:06 PDT
Created attachment 212275 [details]
Patch idea
Comment 2 WebKit Commit Bot 2013-09-21 11:45:02 PDT
Comment on attachment 212275 [details]
Patch idea

Clearing flags on attachment: 212275

Committed r156232: <http://trac.webkit.org/changeset/156232>
Comment 3 WebKit Commit Bot 2013-09-21 11:45:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Jon Lee 2013-09-21 17:10:47 PDT
Changing the binding output should also include change expected test results.
Fixed in http://trac.webkit.org/changeset/156236
Comment 5 Darin Adler 2013-09-21 20:30:10 PDT
Is fastGetAttribute inlined!? I didn’t realize!