Bug 121741 - Web Inspector: show resource request initiator in the details sidebar
Summary: Web Inspector: show resource request initiator in the details sidebar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-21 01:02 PDT by Timothy Hatcher
Modified: 2013-09-23 12:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (15.30 KB, patch)
2013-09-21 01:04 PDT, Timothy Hatcher
joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff
Screenshot (65.32 KB, image/png)
2013-09-21 01:05 PDT, Timothy Hatcher
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-09-21 01:02:29 PDT
We should show the initiator into in the resource details sidebar.

<rdar://problem/5334051>
Comment 1 Timothy Hatcher 2013-09-21 01:04:55 PDT
Created attachment 212263 [details]
Patch
Comment 2 Timothy Hatcher 2013-09-21 01:05:18 PDT
Created attachment 212264 [details]
Screenshot
Comment 3 Joseph Pecoraro 2013-09-23 12:19:43 PDT
Comment on attachment 212263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212263&action=review

r=me

> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:464
> +            for (var i = 0; i < stackTracePayload.length; ++i) {
> +                var callFramePayload = stackTracePayload[i];
> +                if (!callFramePayload.url || callFramePayload.url === "[native code]")
> +                    continue;
> +
> +                url = callFramePayload.url;
> +
> +                // The lineNumber is 1-based, but we expect 0-based.
> +                lineNumber = callFramePayload.lineNumber - 1;
> +
> +                columnNumber = callFramePayload.columnNumber;

Do you want to "break;" here? I would expect that you would want to show the latest stack frame info.
Comment 4 Timothy Hatcher 2013-09-23 12:24:45 PDT
Comment on attachment 212263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212263&action=review

>> Source/WebInspectorUI/UserInterface/FrameResourceManager.js:464
>> +                columnNumber = callFramePayload.columnNumber;
> 
> Do you want to "break;" here? I would expect that you would want to show the latest stack frame info.

Yes, good catch!
Comment 5 Timothy Hatcher 2013-09-23 12:26:44 PDT
http://trac.webkit.org/changeset/156284