Bug 121737 - Get rid of IsInlinedCodeTag and its associated methods since it's unused
Summary: Get rid of IsInlinedCodeTag and its associated methods since it's unused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-21 00:00 PDT by Filip Pizlo
Modified: 2013-09-21 10:40 PDT (History)
7 users (show)

See Also:

Attachments
the patch (4.40 KB, patch)
2013-09-21 00:01 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (11.83 KB, patch)
2013-09-21 01:02 PDT, Filip Pizlo 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-21 00:00:42 PDT 
Nobody sets IsInlinedCodeTag so any code that checks it is dead.
Comment 1 Filip Pizlo 2013-09-21 00:01:33 PDT 
Created attachment 212258 [details]
the patch
Comment 2 Geoffrey Garen 2013-09-21 00:25:37 PDT 
Comment on attachment 212258 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-09-21 00:26:45 PDT 
(In reply to comment #2)
> (From update of attachment 212258 [details])
> r=me

Heh, in the process of trying to convince myself that this was right, I found a bug.  I will have another patch shortly.
Comment 4 Filip Pizlo 2013-09-21 01:02:26 PDT 
Created attachment 212262 [details]
the patch

This does the same thing as the other patch, but also fixes a bug.
Comment 5 Filip Pizlo 2013-09-21 01:03:05 PDT 
Comment on attachment 212262 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212262&action=review

> Source/JavaScriptCore/ChangeLog:37
> +2013-09-21  Filip Pizlo  <fpizlo@apple.com>
> +
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * interpreter/CallFrame.h:
> +        * interpreter/CallFrameInlines.h:
> +        * runtime/Arguments.cpp:
> +        (JSC::Arguments::tearOff):
> +

I will revert this.
Comment 6 Geoffrey Garen 2013-09-21 10:14:10 PDT 
Ha, nice.
Comment 7 Filip Pizlo 2013-09-21 10:40:04 PDT 
Landed in http://trac.webkit.org/changeset/156229