Bug 121734 - Never use ReturnPC for exception handling and quit using exception check indices as a lame replica of the CodeOrigin index
Summary: Never use ReturnPC for exception handling and quit using exception check indi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 121755 121766
Blocks: 121641
  Show dependency tree / graph
 
Reported: 2013-09-20 23:11 PDT by Filip Pizlo
Modified: 2013-09-23 15:08 PDT (History)
10 users (show)

See Also:

Attachments
almost there (37.62 KB, patch)
2013-09-22 21:17 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (56.93 KB, patch)
2013-09-23 12:17 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-09-20 23:11:20 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-09-22 21:17:43 PDT 
Created attachment 212321 [details]
almost there

Still need to, like, compile it.
Comment 2 Filip Pizlo 2013-09-23 12:17:38 PDT 
Created attachment 212378 [details]
the patch
Comment 3 WebKit Commit Bot 2013-09-23 12:21:36 PDT 
Attachment 212378 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/bytecode/CodeBlock.h', u'Source/JavaScriptCore/bytecode/CodeOrigin.h', u'Source/JavaScriptCore/bytecode/InlineCallFrameSet.cpp', u'Source/JavaScriptCore/bytecode/InlineCallFrameSet.h', u'Source/JavaScriptCore/dfg/DFGArgumentsSimplificationPhase.cpp', u'Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp', u'Source/JavaScriptCore/dfg/DFGCommonData.cpp', u'Source/JavaScriptCore/dfg/DFGCommonData.h', u'Source/JavaScriptCore/dfg/DFGDesiredWriteBarriers.cpp', u'Source/JavaScriptCore/dfg/DFGDesiredWriteBarriers.h', u'Source/JavaScriptCore/dfg/DFGGraph.cpp', u'Source/JavaScriptCore/dfg/DFGGraph.h', u'Source/JavaScriptCore/dfg/DFGJITCompiler.cpp', u'Source/JavaScriptCore/dfg/DFGJITCompiler.h', u'Source/JavaScriptCore/dfg/DFGOperations.cpp', u'Source/JavaScriptCore/dfg/DFGOperations.h', u'Source/JavaScriptCore/dfg/DFGRepatch.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp', u'Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp', u'Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp', u'Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp', u'Source/JavaScriptCore/jit/AssemblyHelpers.h']" exit_code: 1
Source/JavaScriptCore/dfg/DFGCommonData.h:73:  The parameter name "codeOrigin" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Hahnenberg 2013-09-23 12:32:03 PDT 
Comment on attachment 212378 [details]
the patch

r=me
Comment 5 Filip Pizlo 2013-09-23 15:08:46 PDT 
Landed in http://trac.webkit.org/changeset/156300