Bug 121721 - Shaders that fail to compile should be marked as such
Summary: Shaders that fail to compile should be marked as such
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-20 14:59 PDT by Dean Jackson
Modified: 2013-09-20 15:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.16 KB, patch)
2013-09-20 15:09 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-09-20 14:59:48 PDT
We expect all output from ANGLE to pass compilation via glCompileShader. Currently we have some test cases that still fail compilation. We'll fix that, but in the meantime we should make sure that we do mark uncompilable shaders as an error.
Comment 1 Radar WebKit Bug Importer 2013-09-20 15:00:24 PDT
<rdar://problem/15044901>
Comment 2 Dean Jackson 2013-09-20 15:09:02 PDT
Created attachment 212228 [details]
Patch
Comment 3 Dean Jackson 2013-09-20 15:16:16 PDT
Committed r156205: <http://trac.webkit.org/changeset/156205>