Bug 121717 - (un)shiftCountWithAnyIndexingType will start over in the middle of copying if it sees a hole
Summary: (un)shiftCountWithAnyIndexingType will start over in the middle of copying if...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 125944
  Show dependency treegraph
 
Reported: 2013-09-20 14:26 PDT by Mark Hahnenberg
Modified: 2013-12-20 17:33 PST (History)
2 users (show)

See Also:


Attachments
Patch (10.27 KB, patch)
2013-09-20 15:08 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-09-20 14:26:05 PDT
This then causes the array to become corrupted. Instead we should check for holes before we start moving things, and start moving things only once we've determined that there are none.
Comment 1 Mark Hahnenberg 2013-09-20 15:08:09 PDT
Created attachment 212227 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-20 17:23:02 PDT
Comment on attachment 212227 [details]
Patch

Clearing flags on attachment: 212227

Committed r156214: <http://trac.webkit.org/changeset/156214>
Comment 3 WebKit Commit Bot 2013-09-20 17:23:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Mark Hahnenberg 2013-09-20 17:25:02 PDT
<rdar://problem/15044692>
Comment 5 Ryosuke Niwa 2013-12-20 17:33:30 PST
This patch caused https://bugs.webkit.org/show_bug.cgi?id=125944