RESOLVED FIXED 121715
Delete TestWebKitAPI domain or some keys before running TestWebKitAPI 
https://bugs.webkit.org/show_bug.cgi?id=121715
Summary Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
David Farler
Reported Friday, September 20, 2013 10:08:42 PM UTC
Some tests may leave values behind for keys that can affect certain tests. There is a current bug in TestWebKitAPI WebKit1.SetAndUpdateCache* tests that is getting masked on some machines due to TestWebKitAPI WebKitCacheModelPreferenceKey == 1 on disk. In particular, at least these tests should be failing but they have been hiding recently on some machines: WebKit1.SetAndUpdateCacheModelInitialModel WebKit1.SetAndUpdateCacheModelPreferencesChangeMix WebKit1.SetAndUpdateCacheModelStandardPreferenceChange
Attachments
Patch (3.42 KB, patch)
2013-09-20 15:37 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (4.51 KB, patch)
2013-09-22 21:23 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (4.20 KB, patch)
2013-09-22 23:15 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (4.04 KB, patch)
2013-09-23 14:46 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
David Farler
Comment 1 Friday, September 20, 2013 10:23:32 PM UTC
<rdar://problem/14269434>
Benjamin Poulain
Comment 2 Friday, September 20, 2013 11:37:09 PM UTC
Created attachment 212230 [details] Patch
Benjamin Poulain
Comment 3 Friday, September 20, 2013 11:37:25 PM UTC
*** Bug 121722 has been marked as a duplicate of this bug. ***
Alexey Proskuryakov
Comment 4 Saturday, September 21, 2013 12:50:50 AM UTC
Comment on attachment 212230 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212230&action=review > Tools/TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:41 > + [NSUserDefaults resetStandardUserDefaults]; I think that we should do this in mainMac.mm and manIOS.mm instead.
Alexey Proskuryakov
Comment 5 Saturday, September 21, 2013 1:37:38 AM UTC
Also, I suspect that WebKit1.DidCreateJavaScriptContextBackForwardCacheTest has the same issue exactly.
Benjamin Poulain
Comment 6 Monday, September 23, 2013 5:23:07 AM UTC
Created attachment 212322 [details] Patch
Alexey Proskuryakov
Comment 7 Monday, September 23, 2013 6:18:57 AM UTC
Comment on attachment 212322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=212322&action=review > Tools/ChangeLog:12 > + This patch fixes the tests by resetting the default, and using the proper I don't see this code in the patch. > Tools/ChangeLog:18 > + * WebKitTestRunner/mac/main.mm: > + (main): These changes don't look related to the fix.
Benjamin Poulain
Comment 8 Monday, September 23, 2013 6:24:24 AM UTC
ahahaha, fuck, I went over this too fast.
Benjamin Poulain
Comment 9 Monday, September 23, 2013 7:15:04 AM UTC
Created attachment 212324 [details] Patch
Alexey Proskuryakov
Comment 10 Monday, September 23, 2013 7:41:01 AM UTC
Comment on attachment 212324 [details] Patch r=me, however I think that this question still stands: > Also, I suspect that WebKit1.DidCreateJavaScriptContextBackForwardCacheTest has the same issue exactly. Please be careful landing this patch - if I'm right, then resetting preferences will make this test fail everywhere, and will make bots red.
Benjamin Poulain
Comment 11 Monday, September 23, 2013 10:46:29 PM UTC
Created attachment 212395 [details] Patch
Alexey Proskuryakov
Comment 12 Monday, September 23, 2013 11:07:25 PM UTC
Yes, this test needed the cache model to be a non-default one. Updated it and landed in <http://trac.webkit.org/r156299>.
Note You need to log in before you can comment on or make changes to this bug.