Bug 121712 – VS2012 IDOM name clash

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit Misc.

[Alex Christensen]

As of 8/26/2013, Microsoft has introduced documented IDOM interfaces in the Windows SDK with names that are the same as ours!  I got WebKit to compile with VS2012, but these are the interfaces I had to rename:

IDOMEvent                 http://msdn.microsoft.com/en-us/library/ff975965(v=vs.85).aspx
IDOMKeyboardEvent         http://msdn.microsoft.com/en-us/library/ff975944(v=vs.85).aspx
IDOMMouseEvent            http://msdn.microsoft.com/en-us/library/ff975920(v=vs.85).aspx
IDOMMutationEvent         http://msdn.microsoft.com/en-us/library/ff975904(v=vs.85).aspx
IDOMWheelEvent            http://msdn.microsoft.com/en-us/library/ff975846(v=vs.85).aspx
IDOMUIEvent               http://msdn.microsoft.com/en-us/library/ff975849(v=vs.85).aspx
IDOMDocumentType          http://msdn.microsoft.com/en-us/library/ff975979(v=vs.85).aspx
IDOMProcessingInstruction http://msdn.microsoft.com/en-us/library/ff975887(v=vs.85).aspx

I'm not sure if it's best to rename our IDOM interfaces that clash (which might require downstream changes if anyone uses these interfaces directly) or to use the Microsoft interfaces (which is outside of my expertise), but here's a patch that appends "WK" to the clashing names.

[Alex Christensen]

Created attachment 212215 [details]
patch

[WebKit Commit Bot]

Attachment 212215 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/DOMCoreClasses.cpp', u'Source/WebKit/win/DOMCoreClasses.h', u'Source/WebKit/win/DOMEventsClasses.cpp', u'Source/WebKit/win/DOMEventsClasses.h', u'Source/WebKit/win/DOMHTMLClasses.h', u'Source/WebKit/win/Interfaces/DOMCore.idl', u'Source/WebKit/win/Interfaces/DOMEvents.idl', u'Tools/ChangeLog', u'Tools/WinLauncher/DOMDefaultImpl.h', u'Tools/WinLauncher/WinLauncher.cpp']" exit_code: 1
Source/WebKit/win/DOMCoreClasses.cpp:431:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMCoreClasses.cpp:785:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMCoreClasses.cpp:913:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMEventsClasses.h:98:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMEventsClasses.h:104:  The parameter name "e" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/win/DOMCoreClasses.h:237:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMCoreClasses.h:451:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMCoreClasses.h:481:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMCoreClasses.h:528:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMCoreClasses.h:610:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMHTMLClasses.h:306:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/win/DOMHTMLClasses.h:336:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 12 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

This problem has magically solved itself.  I'm happy to report that I'm writing this with 64-bit WinLauncher compiled with VS2012.  Maybe we're not including the header with the declaration of Microsoft's IDOMEvents.  There could be a problem if that is true and someone wants to use both COM interfaces in the same project, but I think we should just leave the names as they are so we don't have to change any downstream projects.