WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
121705
WebKit should build against the Xcode default toolchain when targeting OS X 10.8
https://bugs.webkit.org/show_bug.cgi?id=121705
Summary
WebKit should build against the Xcode default toolchain when targeting OS X 10.8
Mark Rowe (bdash)
Reported
2013-09-20 12:37:13 PDT
Created
attachment 212207
[details]
Patch v1 Using the Xcode default toolchain will ensure that we're not using an outdated version of the compiler. <
rdar://problem/14971518
>
Attachments
Patch v1
(17.53 KB, patch)
2013-09-20 12:37 PDT
,
Mark Rowe (bdash)
no flags
Details
Formatted Diff
Diff
Patch v2
(16.60 KB, patch)
2013-09-20 12:43 PDT
,
Mark Rowe (bdash)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2013-09-20 12:43:47 PDT
Created
attachment 212210
[details]
Patch v2
WebKit Commit Bot
Comment 2
2013-09-20 12:47:01 PDT
Attachment 212210
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/Configurations/Base.xcconfig', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/Configurations/Base.xcconfig', u'Source/WTF/ChangeLog', u'Source/WTF/Configurations/Base.xcconfig', u'Source/WebCore/ChangeLog', u'Source/WebCore/Configurations/Base.xcconfig', u'Source/WebInspectorUI/ChangeLog', u'Source/WebInspectorUI/Configurations/Base.xcconfig', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/Configurations/Base.xcconfig', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/Base.xcconfig', u'Tools/ChangeLog', u'Tools/DumpRenderTree/mac/Configurations/Base.xcconfig', u'Tools/MiniBrowser/Configurations/Base.xcconfig', u'Tools/TestWebKitAPI/Configurations/Base.xcconfig', u'Tools/WebKitLauncher/Configurations/Base.xcconfig', u'Tools/WebKitTestRunner/Configurations/Base.xcconfig']" exit_code: 1 Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/ThirdParty/ANGLE/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 8 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3
2013-09-20 14:00:28 PDT
Comment on
attachment 212210
[details]
Patch v2 View in context:
https://bugs.webkit.org/attachment.cgi?id=212210&action=review
r=me
> Source/JavaScriptCore/Configurations/Base.xcconfig:131 > +TOOLCHAINS_iphonesimulator = $(TOOLCHAINS);
I think we normally do something like TOOLCHAINS_iphonesimulator = $(TOOLCHAINS_iphoneos); but I’m not sure if there’s a good reason to do so here.
WebKit Commit Bot
Comment 4
2013-09-24 12:17:37 PDT
Comment on
attachment 212210
[details]
Patch v2 Clearing flags on attachment: 212210 Committed
r156348
: <
http://trac.webkit.org/changeset/156348
>
WebKit Commit Bot
Comment 5
2013-09-24 12:17:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug