Bug 121698 – [GObject] StrictTypeChecking extended attribute fails for methods with sequence<T>

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Antonio Gomes]

+++ This bug was initially created as a clone of Bug #121305 +++

It verify it, comment out the guards below in TestObj.idl, and run run-binding-tests.


228 #if defined(TESTING_JS)   <------
229     [StrictTypeChecking, RaisesException] bool strictFunctionWithSequence(TestObj objArg, sequence<unsigned long> a);
230     [StrictTypeChecking, RaisesException] bool strictFunctionWithArray(TestObj objArg, long[] array);
231 #endif                    <------

[Vineet Chaudhary (vineetc)]

Created attachment 235020 [details]
patch

CodeGenerator was including wrong headers for array parameters.

[Build Bot]

Comment on attachment 235020 [details]
patch

Attachment 235020 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5276653685047296

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html
media/video-ended-event-negative-playback.html

[Build Bot]

Created attachment 235029 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Vineet Chaudhary (vineetc)]

Comment on attachment 235020 [details]
patch

Thank you!!
BTW https://bugs.webkit.org/show_bug.cgi?id=121697 a similar bug is not reproducing.

[WebKit Commit Bot]

Comment on attachment 235020 [details]
patch

Clearing flags on attachment: 235020

Committed r171181: <http://trac.webkit.org/changeset/171181>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.