Bug 121698 - [GObject] StrictTypeChecking extended attribute fails for methods with sequence<T>
Summary: [GObject] StrictTypeChecking extended attribute fails for methods with sequen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 121305
Blocks:
  Show dependency treegraph
 
Reported: 2013-09-20 11:08 PDT by Antonio Gomes
Modified: 2014-07-17 02:30 PDT (History)
10 users (show)

See Also:


Attachments
patch (9.75 KB, patch)
2014-07-16 13:45 PDT, Vineet Chaudhary (vineetc)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (645.28 KB, application/zip)
2014-07-16 15:38 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2013-09-20 11:08:07 PDT
+++ This bug was initially created as a clone of Bug #121305 +++

It verify it, comment out the guards below in TestObj.idl, and run run-binding-tests.


228 #if defined(TESTING_JS)   <------
229     [StrictTypeChecking, RaisesException] bool strictFunctionWithSequence(TestObj objArg, sequence<unsigned long> a);
230     [StrictTypeChecking, RaisesException] bool strictFunctionWithArray(TestObj objArg, long[] array);
231 #endif                    <------
Comment 1 Vineet Chaudhary (vineetc) 2014-07-16 13:45:37 PDT
Created attachment 235020 [details]
patch

CodeGenerator was including wrong headers for array parameters.
Comment 2 Build Bot 2014-07-16 15:38:09 PDT
Comment on attachment 235020 [details]
patch

Attachment 235020 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5276653685047296

New failing tests:
media/W3C/video/src/src_reflects_attribute_not_source_elements.html
media/video-ended-event-negative-playback.html
Comment 3 Build Bot 2014-07-16 15:38:14 PDT
Created attachment 235029 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Vineet Chaudhary (vineetc) 2014-07-17 01:58:08 PDT
Comment on attachment 235020 [details]
patch

Thank you!!
BTW https://bugs.webkit.org/show_bug.cgi?id=121697 a similar bug is not reproducing.
Comment 5 WebKit Commit Bot 2014-07-17 02:30:12 PDT
Comment on attachment 235020 [details]
patch

Clearing flags on attachment: 235020

Committed r171181: <http://trac.webkit.org/changeset/171181>
Comment 6 WebKit Commit Bot 2014-07-17 02:30:17 PDT
All reviewed patches have been landed.  Closing bug.