Bug 121696 - Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we expect a scaled image.
Summary: Add an argument to ImageSource::createFrameAtIndex to hint a decoder that we ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 10:54 PDT by Yongjun Zhang
Modified: 2013-09-20 13:34 PDT (History)
5 users (show)

See Also:

Attachments
add scale to hint platform decoders that we expect a scaled image. (2.89 KB, patch)
2013-09-20 11:16 PDT, Yongjun Zhang 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2013-09-20 10:54:46 PDT 
Some platform image decoders have the capability to decode an image in different scale levels.  If we are going to paint an image in scaled down size, we can hint the decoder to give the image in the right scale to save some memory.
Comment 1 Yongjun Zhang 2013-09-20 11:16:00 PDT 
Created attachment 212197 [details]
add scale to hint platform decoders that we expect a scaled image.
Comment 2 Antti Koivisto 2013-09-20 11:35:36 PDT 
Comment on attachment 212197 [details]
add scale to hint platform decoders that we expect a scaled image.

View in context: https://bugs.webkit.org/attachment.cgi?id=212197&action=review

> Source/WebCore/platform/graphics/ImageSource.h:148
> +    PassNativeImagePtr createFrameAtIndex(size_t, float* scale = 0);

It is not clear if this scale parameter is input, output or both. Maybe a more descriptive name would help?
Comment 3 WebKit Commit Bot 2013-09-20 13:34:34 PDT 
Comment on attachment 212197 [details]
add scale to hint platform decoders that we expect a scaled image.

Clearing flags on attachment: 212197

Committed r156195: <http://trac.webkit.org/changeset/156195>
Comment 4 WebKit Commit Bot 2013-09-20 13:34:36 PDT 
All reviewed patches have been landed.  Closing bug.