Bug 121692 – Move layer hierarchy functions from RenderObject to RenderElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

Text renderers don't need them.

[Antti Koivisto]

Created attachment 212186 [details]
patch

[Antti Koivisto]

Created attachment 212187 [details]
patch 2

[Early Warning System Bot]

Comment on attachment 212187 [details]
patch 2

Attachment 212187 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1803322

[Early Warning System Bot]

Comment on attachment 212187 [details]
patch 2

Attachment 212187 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1803323

[Antti Koivisto]

Created attachment 212193 [details]
patch 3

[Build Bot]

Comment on attachment 212193 [details]
patch 3

Attachment 212193 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1900364

New failing tests:
fast/regions/named-flow-content-order-2.html
fast/block/positioning/absolute-appended-to-inline.html
editing/inserting/line-break.html
fast/regions/webkit-flow-renderer.html
editing/inserting/5058163-1.html
editing/inserting/5418891.html
fast/regions/named-flow-content-order-1.html
editing/inserting/insert-paragraph-03.html
editing/inserting/insert-3800346-fix.html
editing/inserting/insert-br-004.html

[Build Bot]

Created attachment 212201 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Antti Koivisto]

Created attachment 212202 [details]
remember to call base class versions of virtual functions

[Andreas Kling]

Comment on attachment 212202 [details]
remember to call base class versions of virtual functions

View in context: https://bugs.webkit.org/attachment.cgi?id=212202&action=review

r=me

> Source/WebCore/rendering/RenderElement.cpp:203
> +            newObject = 0;

nullptr

> Source/WebCore/rendering/RenderElement.cpp:263
> +        return 0;

nullptr

> Source/WebCore/rendering/RenderElement.cpp:315
> +    RenderLayer* layer = 0;

nullptr

> Source/WebCore/rendering/RenderElement.cpp:334
> +    RenderLayer* layer = 0;

nullptr

> Source/WebCore/rendering/RenderElement.cpp:336
> +        if ((layer = parent()->enclosingLayer()))

Extra () pair here.

[Antti Koivisto]

https://trac.webkit.org/r156190

[Antti Koivisto]

> Extra () pair here.

They are needed.

[Darin Adler]

Comment on attachment 212202 [details]
remember to call base class versions of virtual functions

View in context: https://bugs.webkit.org/attachment.cgi?id=212202&action=review

>> Source/WebCore/rendering/RenderElement.cpp:336
>> +        if ((layer = parent()->enclosingLayer()))
> 
> Extra () pair here.

You need that extra () to tell the compiler that you mean this as an assignment, not an == test. It turns off the warning.