Bug 121686 – [GTK] Stock Items are deprecated in gtk+ 3.10

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKitGTK

[Anton Obzhirov]

* Stock Items:

$ fgrep -lir --include=*.{h,c,cpp} --exclude-dir=WebKitBuild gtk_stock
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp
Source/WebKit/gtk/webkit/webkitwebview.cpp
Source/WebKit/gtk/webkit/webkitauthenticationdialog.cpp
Source/WebCore/platform/graphics/gtk/ImageGtk.cpp
Source/WebCore/platform/graphics/gtk/IconGtk.cpp
Source/WebCore/platform/gtk/RenderThemeGtk.cpp
Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp
Source/WebCore/platform/gtk/ContextMenuItemGtk.cpp
Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
Tools/MiniBrowser/gtk/BrowserSettingsDialog.c
Tools/MiniBrowser/gtk/BrowserWindow.c
Tools/GtkLauncher/main.c

See also 
https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub

[Enrique Ocaña]

Created attachment 218847 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

*** This bug has been marked as a duplicate of bug 120772 ***

[Carlos Garcia Campos]

Comment on attachment 218847 [details]
Patch

Please, make sure this doesn't break anything with our current minimum dependencies. See also https://bugs.webkit.org/show_bug.cgi?id=120772#c6. If this is only internally and it doesn't affect the API nor break existing apps, I'm fine with the change, otherwise I would not do it until we bump the requirements or we break the API/ABI for whatever reason. I see no benefit at all in the stock items deprecation, TBH.