Bug 121686 - [GTK] Stock Items are deprecated in gtk+ 3.10
Summary: [GTK] Stock Items are deprecated in gtk+ 3.10
Status: RESOLVED DUPLICATE of bug 120772
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Anton Obzhirov
URL:
Keywords:
Depends on:
Blocks: 120772
  Show dependency tree / graph
 
Reported: 2013-09-20 08:21 PDT by Anton Obzhirov
Modified: 2014-01-25 10:42 PST (History)
4 users (show)

See Also:

Attachments
Patch (40.96 KB, patch)
2013-12-10 03:02 PST, Enrique Ocaña 		andersca: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Obzhirov 2013-09-20 08:21:05 PDT 
* Stock Items:

$ fgrep -lir --include=*.{h,c,cpp} --exclude-dir=WebKitBuild gtk_stock
Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp
Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp
Source/WebKit/gtk/webkit/webkitwebview.cpp
Source/WebKit/gtk/webkit/webkitauthenticationdialog.cpp
Source/WebCore/platform/graphics/gtk/ImageGtk.cpp
Source/WebCore/platform/graphics/gtk/IconGtk.cpp
Source/WebCore/platform/gtk/RenderThemeGtk.cpp
Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp
Source/WebCore/platform/gtk/WebKitAuthenticationWidget.cpp
Source/WebCore/platform/gtk/ContextMenuItemGtk.cpp
Tools/MiniBrowser/gtk/BrowserDownloadsBar.c
Tools/MiniBrowser/gtk/BrowserSettingsDialog.c
Tools/MiniBrowser/gtk/BrowserWindow.c
Tools/GtkLauncher/main.c

See also 
https://docs.google.com/document/d/1KCVPoYQBqMbDP11tHPpjW6uaEHrvLUmcDPqKAppCY8o/pub
Comment 1 Enrique Ocaña 2013-12-10 03:02:44 PST 
Created attachment 218847 [details]
Patch
Comment 2 WebKit Commit Bot 2013-12-10 03:03:59 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-12-10 03:13:42 PST 

*** This bug has been marked as a duplicate of bug 120772 ***
Comment 4 Carlos Garcia Campos 2014-01-25 10:42:36 PST 
Comment on attachment 218847 [details]
Patch

Please, make sure this doesn't break anything with our current minimum dependencies. See also https://bugs.webkit.org/show_bug.cgi?id=120772#c6. If this is only internally and it doesn't affect the API nor break existing apps, I'm fine with the change, otherwise I would not do it until we bump the requirements or we break the API/ABI for whatever reason. I see no benefit at all in the stock items deprecation, TBH.