Bug 121681 – [Qt] Crash when trying to download blob URL

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Allan Sandfeld Jensen]

If a webpage sets up a link that triggers a download of a blob URL, qtwebkit crashes.

[Allan Sandfeld Jensen]

Created attachment 212163 [details]
Patch

[WebKit Commit Bot]

Attachment 212163 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/qt/ResourceRequestQt.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp']" exit_code: 1
Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:65:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 212163 [details]
Patch

Clearing flags on attachment: 212163

Committed r156330: <http://trac.webkit.org/changeset/156330>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #3)
> (From update of attachment 212163 [details])
> Clearing flags on attachment: 212163
> 
> Committed r156330: <http://trac.webkit.org/changeset/156330>

FYI: It broke the !ENABLE(BLOB) builds.

[Allan Sandfeld Jensen]

(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 212163 [details] [details])
> > Clearing flags on attachment: 212163
> > 
> > Committed r156330: <http://trac.webkit.org/changeset/156330>
> 
> FYI: It broke the !ENABLE(BLOB) builds.

Thanks for the warning. I will try to fix it tomorrow.

[Allan Sandfeld Jensen]

Compile fix for !ENABLE(BLOB) landed in r156394