Bug 121681 - [Qt] Crash when trying to download blob URL
Summary: [Qt] Crash when trying to download blob URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 07:41 PDT by Allan Sandfeld Jensen
Modified: 2013-09-25 07:50 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.90 KB, patch)
2013-09-20 07:45 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-09-20 07:41:06 PDT
If a webpage sets up a link that triggers a download of a blob URL, qtwebkit crashes.
Comment 1 Allan Sandfeld Jensen 2013-09-20 07:45:12 PDT
Created attachment 212163 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-20 07:47:17 PDT
Attachment 212163 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/qt/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/qt/ResourceRequestQt.cpp', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp']" exit_code: 1
Source/WebCore/platform/network/qt/ResourceRequestQt.cpp:65:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2013-09-24 07:15:11 PDT
Comment on attachment 212163 [details]
Patch

Clearing flags on attachment: 212163

Committed r156330: <http://trac.webkit.org/changeset/156330>
Comment 4 WebKit Commit Bot 2013-09-24 07:15:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2013-09-24 16:30:12 PDT
(In reply to comment #3)
> (From update of attachment 212163 [details])
> Clearing flags on attachment: 212163
> 
> Committed r156330: <http://trac.webkit.org/changeset/156330>

FYI: It broke the !ENABLE(BLOB) builds.
Comment 6 Allan Sandfeld Jensen 2013-09-24 16:43:59 PDT
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 212163 [details] [details])
> > Clearing flags on attachment: 212163
> > 
> > Committed r156330: <http://trac.webkit.org/changeset/156330>
> 
> FYI: It broke the !ENABLE(BLOB) builds.

Thanks for the warning. I will try to fix it tomorrow.
Comment 7 Allan Sandfeld Jensen 2013-09-25 07:50:25 PDT
Compile fix for !ENABLE(BLOB) landed in r156394