Bug 121677 - Modified img src and srcset encoded URL tests
Summary: Modified img src and srcset encoded URL tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-20 06:43 PDT by Yoav Weiss
Modified: 2013-09-20 10:28 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.20 KB, patch)
2013-09-20 06:45 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch (6.21 KB, patch)
2013-09-20 06:51 PDT, Yoav Weiss
no flags Details | Formatted Diff | Diff
Patch for landing (6.21 KB, patch)
2013-09-20 07:08 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yoav Weiss 2013-09-20 06:43:58 PDT
Modified img src and srcset encoded URL tests
Comment 1 Yoav Weiss 2013-09-20 06:45:03 PDT
Created attachment 212158 [details]
Patch
Comment 2 Yoav Weiss 2013-09-20 06:47:02 PDT
Previous encoded URL tests for img's src and srcset have broken the Windows builds, since '?' is not a valid char. Moved them to using '@' instead.
Comment 3 WebKit Commit Bot 2013-09-20 06:47:56 PDT
Attachment 212158 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/hidpi/image-srcset-encoded-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-encoded.html', u'LayoutTests/fast/hidpi/image-srcset-question-mark-expected.txt', u'LayoutTests/fast/hidpi/image-srcset-question-mark.html', u'LayoutTests/fast/hidpi/resources/image?test.png', u'LayoutTests/fast/hidpi/resources/image@test.png', u'LayoutTests/fast/loader/image-src-encoded-expected.txt', u'LayoutTests/fast/loader/image-src-question-mark-expected.txt', u'LayoutTests/fast/loader/resources/image?test.png', u'LayoutTests/fast/loader/resources/image@test.png']" exit_code: 1
LayoutTests/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
LayoutTests/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Yoav Weiss 2013-09-20 06:51:49 PDT
Created attachment 212159 [details]
Patch
Comment 5 Patrick R. Gansterer 2013-09-20 07:08:43 PDT
Created attachment 212160 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2013-09-20 07:42:10 PDT
Comment on attachment 212160 [details]
Patch for landing

Clearing flags on attachment: 212160

Committed r156161: <http://trac.webkit.org/changeset/156161>
Comment 7 WebKit Commit Bot 2013-09-20 07:42:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2013-09-20 10:28:12 PDT
This patch lacked one of updated files, fixed in <http://trac.webkit.org/r156179>.