RESOLVED FIXED 121676
Add valueForLength/minimumValueForLength wrappers to RenderObject. 
https://bugs.webkit.org/show_bug.cgi?id=121676
Summary Add valueForLength/minimumValueForLength wrappers to RenderObject.
Andreas Kling
Reported 2013-09-20 06:29:37 PDT
So much "&view()" everywhere.
Attachments
Patch idea (62.56 KB, patch)
2013-09-20 06:30 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Land (62.69 KB, patch)
2013-09-20 08:17 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-20 06:30:29 PDT
Created attachment 212157 [details] Patch idea
Antti Koivisto
Comment 2 2013-09-20 06:43:00 PDT
Comment on attachment 212157 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=212157&action=review > Source/WebCore/rendering/RenderObject.h:1003 > + LayoutUnit valueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages = false) const > + { > + return WebCore::valueForLength(length, maximumValue, &view(), roundPercentages); > + } > + > + LayoutUnit minimumValueForLength(const Length& length, LayoutUnit maximumValue, bool roundPercentages = false) const > + { > + return WebCore::minimumValueForLength(length, maximumValue, &view(), roundPercentages); > + } RenderText should not have any valid uses for these. Please move to RenderElement.
Andreas Kling
Comment 3 2013-09-20 08:17:50 PDT
Created attachment 212168 [details] Land
WebKit Commit Bot
Comment 4 2013-09-20 08:33:15 PDT
Comment on attachment 212168 [details] Land Clearing flags on attachment: 212168 Committed r156166: <http://trac.webkit.org/changeset/156166>
WebKit Commit Bot
Comment 5 2013-09-20 08:33:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.