Bug 121662 - BitVector::OutOfLineBits is always reported as a leak
Summary: BitVector::OutOfLineBits is always reported as a leak
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-09-20 01:00 PDT by Alexey Proskuryakov
Modified: 2020-03-04 10:17 PST (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-09-20 01:00:12 PDT
BitVector::m_bitsOrPointer stores a transmogrified OutOfLineBits pointer, so it's always reported as a leak:

    m_bitsOrPointer = bitwise_cast<uintptr_t>(newOutOfLineBits) >> 1;
Comment 1 Radar WebKit Bug Importer 2017-11-30 00:16:35 PST
<rdar://problem/35767785>
Comment 2 Alexey Proskuryakov 2017-11-30 00:22:57 PST
Silenced the leak in <http://trac.webkit.org/r225321>.

It still needs to be fixed, as it will continue to show up as a leak for client apps which don't use webkitpy for leaks detection.
Comment 3 Alexey Proskuryakov 2017-12-18 08:39:43 PST
I'm not seeing many leaks under BitVector::resizeOutOfLine too. I don't see any recent changes to this code, so perhaps that's just because I ran a more complete set of tests.

Adding BitVector::resizeOutOfLine to _callstacks_to_exclude_from_leaks too.
Comment 4 Alexey Proskuryakov 2017-12-18 09:07:14 PST
> I'm not seeing

I'm *now* seeing