Bug 121650 - ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
Summary: ASSERTs in isMainThread after USE(WEB_THREAD) MainThread changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 18:03 PDT by Joseph Pecoraro
Modified: 2013-09-19 18:40 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.31 KB, patch)
2013-09-19 18:04 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-09-19 18:03:11 PDT 
I broke Safari Extensions with my change outside of USE(WEB_THREAD):

1   0x10cc62680 WTFCrash
2   0x10cc85ffa WTF::isMainThread()
3   0x10ead5836 WebCore::localizedString(char const*)
4   0x10b41d4f8 WebKit::WebProcess::initializeProcessName(WebKit::ChildProcessInitializationParameters const&)
5   0x10b0073c7 WebKit::ChildProcess::initialize(WebKit::ChildProcessInitializationParameters const&)
6   0x10b25b2aa int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebContentProcessMainDelegate>(int, char**)
7   0x10b25b08b WebContentProcessMain
8   0x10afa3d18 WebKit::BootstrapMain(int, char**)
9   0x10afa3b92 main

So I will suggest a more targeted fix not changing anything outside of USE(WEB_THREAD).
Comment 1 Joseph Pecoraro 2013-09-19 18:04:48 PDT 
Created attachment 212111 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2013-09-19 18:40:16 PDT 
Comment on attachment 212111 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 212111

Committed r156134: <http://trac.webkit.org/changeset/156134>
Comment 3 WebKit Commit Bot 2013-09-19 18:40:18 PDT 
All reviewed patches have been landed.  Closing bug.