Bug 121645 - Counter shouldn't invalidate the tree in the middle of layout
Summary: Counter shouldn't invalidate the tree in the middle of layout
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 16:25 PDT by Ryosuke Niwa
Modified: 2016-04-25 08:50 PDT (History)
10 users (show)

See Also:

Attachments
Fixes the bug (7.15 KB, patch)
2013-09-19 16:45 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Updated for ToT (7.15 KB, patch)
2013-09-19 16:48 PDT, Ryosuke Niwa 		dbates: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-09-19 16:25:55 PDT 
Counter shouldn't invalidate the tree in the middle of layout
Comment 1 Ryosuke Niwa 2013-09-19 16:45:39 PDT 
Created attachment 212107 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2013-09-19 16:48:25 PDT 
Created attachment 212108 [details]
Updated for ToT
Comment 3 Simon Fraser (smfr) 2013-09-23 11:59:55 PDT 
Comment on attachment 212108 [details]
Updated for ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=212108&action=review

> Source/WebCore/page/FrameView.cpp:2867
> +    for (RenderObject* renderer = view; renderer; renderer = renderer->nextInPreOrder()) {
> +        if (!renderer->isCounter())
> +            continue;
> +
> +        static_cast<RenderCounter*>(renderer)->updateCounter();
> +    }

We walk the entire render tree to update counters? That's crazy! We should keep a hash set of counter renderers.
Comment 4 Daniel Bates 2016-04-23 12:18:03 PDT 
Comment on attachment 212108 [details]
Updated for ToT

r- by comment #3.
Comment 5 Ryosuke Niwa 2016-04-23 21:12:13 PDT 
I'm not working on this.