Bug 121638 - Add covariant RenderElement* Element::renderer()
Summary: Add covariant RenderElement* Element::renderer()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 121640
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-19 14:24 PDT by Antti Koivisto
Modified: 2013-09-20 03:59 PDT (History)
10 users (show)

See Also:

Attachments
patch (10.90 KB, patch)
2013-09-19 14:28 PDT, Antti Koivisto 		kling: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
for bots (12.80 KB, patch)
2013-09-20 01:22 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
another (13.28 KB, patch)
2013-09-20 01:42 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
yet another (13.77 KB, patch)
2013-09-20 01:51 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-19 14:24:20 PDT 
Tighter typing.
Comment 1 Antti Koivisto 2013-09-19 14:28:57 PDT 
Created attachment 212096 [details]
patch
Comment 2 Andreas Kling 2013-09-19 14:37:04 PDT 
Comment on attachment 212096 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212096&action=review

> Source/WebCore/ChangeLog:3
> +        Add covariant RenderElement* ContainerNode::renderer()

ContainerNode -> RenderElement -> Element
This is pretty weird-looking. :)
Comment 3 Early Warning System Bot 2013-09-19 14:40:44 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1955236
Comment 4 Early Warning System Bot 2013-09-19 14:44:57 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1949289
Comment 5 EFL EWS Bot 2013-09-19 14:59:45 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1999166
Comment 6 Build Bot 2013-09-19 15:07:24 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1949293
Comment 7 Build Bot 2013-09-19 15:28:00 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1999168
Comment 8 EFL EWS Bot 2013-09-19 15:33:30 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/2010018
Comment 9 Build Bot 2013-09-19 18:10:45 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1867300
Comment 10 kov's GTK+ EWS bot 2013-09-19 18:37:07 PDT 
Comment on attachment 212096 [details]
patch

Attachment 212096 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1959039
Comment 11 Antti Koivisto 2013-09-20 01:22:13 PDT 
Created attachment 212130 [details]
for bots
Comment 12 Antti Koivisto 2013-09-20 01:23:54 PDT 
(In reply to comment #2)
> (From update of attachment 212096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=212096&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Add covariant RenderElement* ContainerNode::renderer()
> 
> ContainerNode -> RenderElement -> Element
> This is pretty weird-looking. :)

Moved it to 

RenderElement* Element::renderer()

which makes more sense. While all ContainerNode renderers are RenderElements it makes more semantic sense to have it in Element. ContainerNode is not that popular of a type.
Comment 13 Antti Koivisto 2013-09-20 01:42:53 PDT 
Created attachment 212132 [details]
another
Comment 14 Antti Koivisto 2013-09-20 01:51:11 PDT 
Created attachment 212134 [details]
yet another
Comment 15 Antti Koivisto 2013-09-20 01:58:39 PDT 
https://trac.webkit.org/r156144
Comment 16 Csaba Osztrogonác 2013-09-20 03:59:20 PDT 
(In reply to comment #15)
> https://trac.webkit.org/r156144

and the Windows buildfix landed in http://trac.webkit.org/changeset/156148