Bug 121633 – [GTK] Clean up the Skip* functions in the GObject DOM bindings code generator

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Martin Robinson]

These functions are used for skipping attributes and functions that we do not support. There is a lot of code that call these functions and then tacks on other criteria for skipping. That extra code should go into the SkipFoo function itself.

[Martin Robinson]

Created attachment 212104 [details]
Patch

[Gustavo Noronha (kov)]

Comment on attachment 212104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212104&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-247
> -

nit: does this improve readability in your opinion?

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-907
> -        if ($paramIDLType eq "EventListener" || $paramIDLType eq "MediaQueryListListener") {
> -            # EventListeners are handled elsewhere.
> -            return;
> -        }

Where are these skipped in this for loop? Or do they not even get here in the function->parameters?

[Martin Robinson]

Comment on attachment 212104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212104&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-247
>> -
> 
> nit: does this improve readability in your opinion?

I clumped these because they are all used in the following block. I'm happy to restore the newline though. :)

>> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:-907
>> -        }
> 
> Where are these skipped in this for loop? Or do they not even get here in the function->parameters?

These are skipped at line 880/890.

[Martin Robinson]

Committed r156182: <http://trac.webkit.org/changeset/156182>