Bug 121608 - Add RenderElement
Summary: Add RenderElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 07:33 PDT by Antti Koivisto
Modified: 2013-09-19 12:02 PDT (History)
5 users (show)

See Also:


Attachments
patch (36.62 KB, patch)
2013-09-19 07:46 PDT, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
export the new header (38.06 KB, patch)
2013-09-19 08:50 PDT, Antti Koivisto
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-19 07:33:52 PDT
RenderObject
    RenderText
    RenderElement
        RenderLayerModelObject
        RenderSVGModelObject
        RenderSVGGradientStop
Comment 1 Antti Koivisto 2013-09-19 07:46:30 PDT
Created attachment 212067 [details]
patch
Comment 2 Build Bot 2013-09-19 08:07:05 PDT
Comment on attachment 212067 [details]
patch

Attachment 212067 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1968178
Comment 3 Build Bot 2013-09-19 08:15:04 PDT
Comment on attachment 212067 [details]
patch

Attachment 212067 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/2009023
Comment 4 Antti Koivisto 2013-09-19 08:50:24 PDT
Created attachment 212074 [details]
export the new header
Comment 5 Dave Hyatt 2013-09-19 10:46:20 PDT
Comment on attachment 212074 [details]
export the new header

r=me
Comment 6 Ryosuke Niwa 2013-09-19 10:50:41 PDT
Comment on attachment 212074 [details]
export the new header

View in context: https://bugs.webkit.org/attachment.cgi?id=212074&action=review

> Source/WebCore/rendering/RenderElement.cpp:131
> +
> +    return nullptr;

Shouldn't we have ASSERT_NOT_REACHED here?
Comment 7 Antti Koivisto 2013-09-19 10:52:18 PDT
https://trac.webkit.org/r156102
Comment 8 Antti Koivisto 2013-09-19 10:53:19 PDT
(In reply to comment #6)
> Shouldn't we have ASSERT_NOT_REACHED here?

Not sure. Someone should find out.
Comment 9 Ryosuke Niwa 2013-09-19 10:54:42 PDT
The switch above it handles all cases in the enum so unless the enum value becomes bogus, we should never reach there.
Comment 10 Antti Koivisto 2013-09-19 12:02:33 PDT
(In reply to comment #9)
> The switch above it handles all cases in the enum so unless the enum value becomes bogus, we should never reach there.

Ah ok. I didn't realize it covers all. I'll add the assert.