RESOLVED FIXED 121608
Add RenderElement 
https://bugs.webkit.org/show_bug.cgi?id=121608
Summary Add RenderElement
Antti Koivisto
Reported 2013-09-19 07:33:52 PDT
RenderObject RenderText RenderElement RenderLayerModelObject RenderSVGModelObject RenderSVGGradientStop
Attachments
patch (36.62 KB, patch)
2013-09-19 07:46 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
export the new header (38.06 KB, patch)
2013-09-19 08:50 PDT, Antti Koivisto 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-09-19 07:46:30 PDT
Created attachment 212067 [details] patch
Build Bot
Comment 2 2013-09-19 08:07:05 PDT
Comment on attachment 212067 [details] patch Attachment 212067 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1968178
Build Bot
Comment 3 2013-09-19 08:15:04 PDT
Comment on attachment 212067 [details] patch Attachment 212067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2009023
Antti Koivisto
Comment 4 2013-09-19 08:50:24 PDT
Created attachment 212074 [details] export the new header
Dave Hyatt
Comment 5 2013-09-19 10:46:20 PDT
Comment on attachment 212074 [details] export the new header r=me
Ryosuke Niwa
Comment 6 2013-09-19 10:50:41 PDT
Comment on attachment 212074 [details] export the new header View in context: https://bugs.webkit.org/attachment.cgi?id=212074&action=review > Source/WebCore/rendering/RenderElement.cpp:131 > + > + return nullptr; Shouldn't we have ASSERT_NOT_REACHED here?
Antti Koivisto
Comment 7 2013-09-19 10:52:18 PDT
https://trac.webkit.org/r156102
Antti Koivisto
Comment 8 2013-09-19 10:53:19 PDT
(In reply to comment #6) > Shouldn't we have ASSERT_NOT_REACHED here? Not sure. Someone should find out.
Ryosuke Niwa
Comment 9 2013-09-19 10:54:42 PDT
The switch above it handles all cases in the enum so unless the enum value becomes bogus, we should never reach there.
Antti Koivisto
Comment 10 2013-09-19 12:02:33 PDT
(In reply to comment #9) > The switch above it handles all cases in the enum so unless the enum value becomes bogus, we should never reach there. Ah ok. I didn't realize it covers all. I'll add the assert.
Note You need to log in before you can comment on or make changes to this bug.