RenderObject RenderText RenderElement RenderLayerModelObject RenderSVGModelObject RenderSVGGradientStop
Created attachment 212067 [details] patch
Comment on attachment 212067 [details] patch Attachment 212067 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1968178
Comment on attachment 212067 [details] patch Attachment 212067 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/2009023
Created attachment 212074 [details] export the new header
Comment on attachment 212074 [details] export the new header r=me
Comment on attachment 212074 [details] export the new header View in context: https://bugs.webkit.org/attachment.cgi?id=212074&action=review > Source/WebCore/rendering/RenderElement.cpp:131 > + > + return nullptr; Shouldn't we have ASSERT_NOT_REACHED here?
https://trac.webkit.org/r156102
(In reply to comment #6) > Shouldn't we have ASSERT_NOT_REACHED here? Not sure. Someone should find out.
The switch above it handles all cases in the enum so unless the enum value becomes bogus, we should never reach there.
(In reply to comment #9) > The switch above it handles all cases in the enum so unless the enum value becomes bogus, we should never reach there. Ah ok. I didn't realize it covers all. I'll add the assert.