Bug 121607 - [EFL] Fix incorrect click counting in EventSenderProxy
Summary: [EFL] Fix incorrect click counting in EventSenderProxy
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 06:54 PDT by Krzysztof Wolanski
Modified: 2017-03-11 10:44 PST (History)
7 users (show)

See Also:

Attachments
proposed patch (2.38 KB, patch)
2013-09-19 06:56 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
apply suggestions (2.45 KB, patch)
2013-09-23 01:58 PDT, Krzysztof Wolanski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Wolanski 2013-09-19 06:54:40 PDT 
Previously used two types of recording time, which conflicted with each other.
Comment 1 Krzysztof Wolanski 2013-09-19 06:56:58 PDT 
Created attachment 212063 [details]
proposed patch
Comment 2 Gyuyoung Kim 2013-09-23 01:22:45 PDT 
Comment on attachment 212063 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212063&action=review

> LayoutTests/ChangeLog:3
> +        [EFL] Gardening

Use same bug title.

> Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp:369
> +    m_clickTime = currentEventTime();

Other ports are using 'm_time' variable directly. But, I don't mind to use currentEventTime().
Comment 3 Krzysztof Wolanski 2013-09-23 01:58:20 PDT 
Created attachment 212335 [details]
apply suggestions
Comment 4 Gyuyoung Kim 2013-09-23 01:59:24 PDT 
Comment on attachment 212335 [details]
apply suggestions

View in context: https://bugs.webkit.org/attachment.cgi?id=212335&action=review

> LayoutTests/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=12046911111111111111111111111

Wrong url....

> Tools/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=12148511111111111111

ditto.
Comment 5 Gyuyoung Kim 2013-09-23 02:02:10 PDT 
Comment on attachment 212335 [details]
apply suggestions

View in context: https://bugs.webkit.org/attachment.cgi?id=212335&action=review

> LayoutTests/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=12046911111111111111111111111

Wrong url....

> Tools/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=12148511111111111111

ditto.
Comment 6 Michael Catanzaro 2017-03-11 10:44:43 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.