Bug 121600 - [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
Summary: [GTK][WK2] A plugin dirtyRect within iframe remains after moving to a differe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 03:25 PDT by ChangSeok Oh
Modified: 2013-09-23 20:16 PDT (History)
3 users (show)

See Also:

Attachments
TestCase (22.82 KB, application/gzip)
2013-09-19 03:25 PDT, ChangSeok Oh 		no flags Details
Patch (1.59 KB, patch)
2013-09-20 02:54 PDT, ChangSeok Oh 		gustavo: review+
Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2013-09-23 12:13 PDT, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-09-19 03:25:01 PDT 
Created attachment 212046 [details]
TestCase

Find the attached file which shows the bug.
Comment 1 ChangSeok Oh 2013-09-20 02:54:43 PDT 
Created attachment 212141 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-09-23 05:55:44 PDT 
Comment on attachment 212141 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=212141&action=review

> Source/WebKit2/ChangeLog:8
> +        Nowhere to destory NetscapePlugin::m_platformPluginWidget even after destroying

destory -> destroy

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:304
> +#if PLATFORM(GTK)
> +    if (m_platformPluginWidget)
> +        gtk_widget_destroy(m_platformPluginWidget);
> +#endif

The drawable is set to 0, do you know why is that? I think we should do this here too, for consistency in any case.
Comment 3 ChangSeok Oh 2013-09-23 12:13:23 PDT 
Created attachment 212377 [details]
Patch
Comment 4 WebKit Commit Bot 2013-09-23 13:08:33 PDT 
Comment on attachment 212377 [details]
Patch

Clearing flags on attachment: 212377

Committed r156287: <http://trac.webkit.org/changeset/156287>