Bug 121596 - [CTTE] RenderText is always anonymous or associated with Text node
Summary: [CTTE] RenderText is always anonymous or associated with Text node
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-19 01:06 PDT by Antti Koivisto
Modified: 2013-09-19 03:37 PDT (History)
1 user (show)

See Also:


Attachments
patch (37.55 KB, patch)
2013-09-19 01:28 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
with updated mathml test results (123.95 KB, patch)
2013-09-19 02:12 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-09-19 01:06:09 PDT
Tighten until it snaps
Comment 1 Antti Koivisto 2013-09-19 01:28:18 PDT
Created attachment 212042 [details]
patch
Comment 2 Antti Koivisto 2013-09-19 02:12:23 PDT
Created attachment 212043 [details]
with updated mathml test results
Comment 3 Andreas Kling 2013-09-19 03:22:00 PDT
Comment on attachment 212043 [details]
with updated mathml test results

View in context: https://bugs.webkit.org/attachment.cgi?id=212043&action=review

> Source/WebCore/rendering/RenderCounter.h:50
> +    RenderCounter(const CounterContent&);

explicit

> Source/WebCore/rendering/RenderQuote.h:39
> +    RenderQuote(QuoteType);

explicit

> Source/WebCore/rendering/RenderText.cpp:166
> -    view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length());
> +    if (textNode)
> +        view().frameView().incrementVisuallyNonEmptyCharacterCount(m_text.length());

This is so ugly. I wish we had alternate constructors for this kind of thing, so view() is always guaranteed to work.
Comment 4 Antti Koivisto 2013-09-19 03:37:47 PDT
http://trac.webkit.org/changeset/156090