Bug 121591 - REGRESSION (r149928): CanvasStyle::operator= leaks everything
Summary: REGRESSION (r149928): CanvasStyle::operator= leaks everything
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2013-09-19 00:32 PDT by Alexey Proskuryakov
Modified: 2013-09-19 09:37 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (1.48 KB, patch)
2013-09-19 00:35 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-09-19 00:32:55 PDT 
There is a reason why dirty tricks are not advisable, and the reason is that they are difficult to get right :)
Comment 1 Alexey Proskuryakov 2013-09-19 00:35:43 PDT 
Created attachment 212038 [details]
proposed fix

Just fix the leak. It would be nice to make the code less unusual at some point.
Comment 2 Alexey Proskuryakov 2013-09-19 00:36:34 PDT 
(this leak is very visible on leaks bot, not just theoretical)
Comment 3 Andreas Kling 2013-09-19 06:04:18 PDT 
Comment on attachment 212038 [details]
proposed fix

:|
Comment 4 WebKit Commit Bot 2013-09-19 08:59:32 PDT 
Comment on attachment 212038 [details]
proposed fix

Clearing flags on attachment: 212038

Committed r156099: <http://trac.webkit.org/changeset/156099>
Comment 5 WebKit Commit Bot 2013-09-19 08:59:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2013-09-19 09:37:44 PDT 
<rdar://problem/15031018>